chore(test): format text with playwright#8001
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
max-nextcloud
force-pushed
the
chore/convert-cy-to-play
branch
3 times, most recently
from
e8f11db to
612b380
Compare
|
Print spec looks like somehow the table width shrank |
The table width in edit mode is smaller than in readonly mode nowadays, as the edit buttons don't exist in readonly mode and we use the available extra space there. That was requested by the design team some months back and I implemented it. |
Nice! That explains it as i just made the share editable - but maybe we should not apply this in print view as no buttons are visible there either. |
Signed-off-by: Max <max@nextcloud.com>
There are no buttons that we would need to leave room for. This way the print view looks the same between editable and readonly shares. Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
force-pushed
the
chore/convert-cy-to-play
branch
from
3e51cd2 to
d78ee67
Compare
mejo-
left a comment
mejo-
left a comment
There was a problem hiding this comment.
Looks good to me. I wonder whether the cypress test "Initializes the workspace without errors" is necessary as I would expect the workspace to not be visible if an error was thrown, but maybe I'm missing something there.
We are logging some exceptions rather than throwing them. I think this is a regression test for a fix that removed one of these errors. |
2 participants
Summary
Migrating some more tests to playwright.