fix(PlainTable): Add paragraph node, required for table cells#8052
Merged
fix(PlainTable): Add paragraph node, required for table cells#8052
Conversation
No need to open Text in Viewer to test `window.OCA.Text.createTable()`. Signed-off-by: Jonas <jonas@freesources.org>
With table cells now requiring a block node as content, the paragraph node is needed to allow any content in a table cell. Signed-off-by: Jonas <jonas@freesources.org>
max-nextcloud
approved these changes
Dec 13, 2025
Collaborator
max-nextcloud
left a comment
max-nextcloud
left a comment
There was a problem hiding this comment.
Thanks for the quick fix!
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Collaborator
|
thank you for the test fixes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With table cells now requiring a block node as content, the paragraph node is needed to allow any content in a table cell.
Also slightly improves
create-table-api.spec.ts. No need to open Text in Viewer to testwindow.OCA.Text.createTable().🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)