test(playwright): add basic tests for editor API#8072
Conversation
fcea4c9 to
e5a8e45
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
max-nextcloud
left a comment
There was a problem hiding this comment.
All in all looks good. The create...Editor functions could be moved into fixtures for easier reuse. But we can also do that later, just need to make sure not to copy them anywhere else / rewrite them.
e5a8e45 to
ae3f0da
Compare
That's a good point. I refactored the tests with help of copilot and think they're much cleaner structured now. Let me know what you think 😊 |
ae3f0da to
253ee01
Compare
max-nextcloud
left a comment
There was a problem hiding this comment.
Just some comments. I think the AI artifacts are showing. 😉
| }, | ||
| ) => { | ||
| const containerId = options.containerId ?? 'test-editor-api' | ||
| const containerId = 'test-editor-api' |
There was a problem hiding this comment.
You're not using the containerId fixture from below. So I think you can either do away with it or add it above to the { page }.
There was a problem hiding this comment.
I don't see a reason to make it configurable. At the same time it needs to be exposed by the fixture as the tests need it in order to use it in CSS selectors.
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
…itor Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
253ee01 to
19c2ffb
Compare
…ions Signed-off-by: Jonas <jonas@freesources.org>
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)