Conversation
Collaborator
max-nextcloud
commented
Dec 17, 2025
max-nextcloud
commented
- cleanup unused heading.previous
- headings: keep anchors and intersection observer
- headings: lookup anchors within current editor
max-nextcloud
force-pushed
the
fix/anchor-observer
branch
from
0ed8bce to
799bcad
Compare
mejo-
reviewed
Dec 17, 2025
Member
mejo-
left a comment
mejo-
left a comment
There was a problem hiding this comment.
Looks great. I skimmed through the code changes and have two comments so far 😊
mejo-
reviewed
Dec 17, 2025
max-nextcloud
force-pushed
the
fix/anchor-observer
branch
2 times, most recently
from
0952139 to
21efc34
Compare
Also type headingAnchor and extractHeadings Signed-off-by: Max <max@nextcloud.com>
No need to create all heading anchors from scratch if one changes. This also allows us to keep the intersection observer and only adjust the targets when headings are added / removed. Signed-off-by: Max <max@nextcloud.com>
The element id should be unique according to the html spec - but we cannot guarantee this as multiple editors may be rendered at the same time. Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
force-pushed
the
fix/anchor-observer
branch
from
21efc34 to
b11fa5a
Compare
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Script setup does not expose vm internals by default. So we cannot rely on them for tests. Otherwise would have to expose them with [defineExpose](https://vuejs.org/api/sfc-script-setup.html#defineexpose). But it seems better to test for actual dom changes in components and test state with composable tests. Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
force-pushed
the
fix/anchor-observer
branch
from
b11fa5a to
6a10da1
Compare
Signed-off-by: Max <max@nextcloud.com>
mejo-
approved these changes
Dec 18, 2025
Member
mejo-
left a comment
mejo-
left a comment
There was a problem hiding this comment.
Really nice work, thanks so much ❤️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
