fix: Register the dav plugin through an event listener#943
Merged
Conversation
icewind1991
approved these changes
Apr 15, 2025
Sabre plugins from info.xml are loaded only after auth has taken place, this is too late for user_saml. So this goes back to using an event, but uses the modern typed version. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
fix/fix-sabre-plugin-registering
branch
from
69f3225 to
4c58743
Compare
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
blizzz
approved these changes
Apr 15, 2025
Contributor
Author
|
https://github.com/nextcloud/server/actions/runs/14472621054/job/40592798421 Not fixed yet it seems. |
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Contributor
Author
|
It’s a mistery to me why we are not listening to SabrePluginAuthInitEvent instead, but as this is complicated enough, for now listening to the same event as before to make sure it does not break anything. |
Contributor
Author
|
https://github.com/nextcloud/server/actions/runs/14472621054/job/40594700851 now it works, good for merging. |
4 tasks
Member
|
Thanks @come-nc 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sabre plugins from info.xml are loaded only after auth has taken place,
this is too late for user_saml. So this goes back to using an event,
but uses the modern typed version.