Add cast kinds for bool, int, string#1098
Conversation
| $binary = (binary) $binary; | ||
| ----- | ||
| $int = (int) $int; | ||
| $integer = (int) $integer; |
There was a problem hiding this comment.
I kept the previous behavior that converts the aliased casts to their un-alised casts for backward compatibility while writing. This is in contrast to double-like casts, where pExpr_Cast_Double() considers the original kind.
|
This is to detect deprecated cast kinds? |
|
@nikic Yes, exactly. |
|
@mttsch could you check whether this PR broke the PHP8.5 unit tests (see latest master commit which added PHP8.5 coverage after this PR)? |
|
@staabm The issue does not exist for the tagged alpha4 version: I am not sure if I want to/can spend the time to set up a PHP setup/container with the latest commit (or same commit as in CI) from the php-src at the moment. PS: … I will try setting it up this evening if time permits. |
|
That was due to a php-src bug that I already fixed in php/php-src#19438. |
|
awesome thanks for the feedback |
No description provided.