fix: ps1 scripts in powershell 5.1#8469
Merged
wraithgar merged 1 commit intonpm:latestfrom Aug 4, 2025
Merged
Conversation
bcc017b to
3ee2565
Compare
… mode is enabled.
3ee2565 to
4d90d3c
Compare
Contributor
|
can we change if (($MyInvocation | Get-Member -Name 'Statement') -and $MyInvocation.Statement) {to if ($MyInvocation | Get-Member -Name 'Statement') {Otherwise, this PR looks good to me @wraithgar @mbtools |
Contributor
|
Don't know how many people will run into this issue but it is in NodeJS 22.18.0+ / 24.3.0+ |
Contributor
Author
I think we should keep both. The first checks that the |
Contributor
|
@splatteredbits Ok I understand the difference now |
Contributor
|
Lgtm |
wraithgar
approved these changes
Aug 4, 2025
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #8468: npm.ps1 and npx.ps1 fail on Windows PowerShell 5.1 when run in strict mode.
References