Merged
Conversation
partial revert of 2af31dd cafile and certfile are both valid and mean different things - certfile is the path to the certificate file (complements keyfile) - cafile is the path to the certificate authority file also clarify that keyfile and certfile must be scoped to a registry
Member
|
This is a good start, and worth landing as-is. There is a bit of a weird gray area for certfile and keyfile in that they are allowed as nerf-dart configs but they have no actual definition or validation. Normally that's not a huge concern because they aren't things users normally set via Somewhere on our long backlog we should consider making this a less opaque setup. |
wraithgar
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial revert of #7947
certfileandcafileare both valid, and are used for different things:certfileis the path to the certificate file. It's used for mutual TLS and represents the client's certificate (supersedes the deprecatedcert, and complementskeyfile).cafileis the path to the certificate authority file. It's used to verify the authenticity of the registry's certificate.Also clarify that
keyfileandcertfilemust be scoped to a registry.