Icon for Visual Studio Code (vscode)

[edgard]

vS code has been release today as 1.0 and the icon is not being used for the deb package. I noticed that there is already a visualstudiocode.svg, but the .desktop file is as follows:

/usr/share/applications/code.desktop

[Desktop Entry]
Name=Visual Studio Code
Comment=Code Editing. Redefined.
GenericName=Text Editor
Exec=/usr/bin/code %U
Icon=code
Type=Application
StartupNotify=true
Categories=Utility;TextEditor;Development;IDE;
MimeType=text/plain;

Suppose it needs a new symlink?

[palob]

Hmm, just code is quite the generic icon name.

[edgard]

heh, yeah. but maybe because it's so generic, it seems like nobody dared to use before. :D

[Foggalong]

@edgard That's not a good thing, that's a bad thing. Generic icon names are likely to cause conflicts. I'd wager just symlink this to the generic text editor icon. It's better than nothing and I'm not sure we can comfortably fix this as just a VSCode icon.

[edgard]

While I also do not like its called 'code' (even the cli), it's how it is right now. They oficially packaged like that. :)

[andia89]

Is it possible to include a "fix" for that in the hardcode fixer script?

[Foggalong]

@edgard Yeah, they might have packaged it like that but it doesn't mean they've done it right. Lots of devs use icon.svg as an icon name but it's a pain for the same reason. We can't give it a specific icon because they used too generic a name which others are likely to also use. Please report it to them and ask for a fix.

@wa4557 wecould, yeah

[icasdri]

I'm on a different distribution (namely Arch), that is currently packaging (unofficially by community members) with a different Icon line. So maybe hardcode fix and add icon for something like this while still generically linking "code" to text editor icon?

[Desktop Entry]
Categories=Development;
Exec=/usr/bin/visual-studio-code %f
Icon=visual-studio-code
Terminal=false
Type=Application
StartupWMClass=code
Name=Visual Studio Code
Comment=Editor for building and debugging modern web and cloud applications
Categories=Development;WebDevelopment;IDE;
StartupNotify=true

[ismaelgv]

This should be reported upstream. I agree that code is not a proper icon name. Each distro is packaging it with a different name in its desktop file.

The original code.desktop has a placeholder called @@NAME@@. I really can't see the reason of this design.