API: Add Array API aliases (math, bitwise, linalg, misc) [Array API]#25086
Merged
ngoldbaum merged 3 commits intonumpy:mainfrom Dec 8, 2023
Merged
API: Add Array API aliases (math, bitwise, linalg, misc) [Array API]#25086ngoldbaum merged 3 commits intonumpy:mainfrom
ngoldbaum merged 3 commits intonumpy:mainfrom
Conversation
23 tasks
mtsokol
force-pushed
the
array-api-aliases
branch
from
78e94b2 to
4a1c7e5
Compare
mtsokol
changed the title
eendebakpt
reviewed
Nov 7, 2023
eendebakpt
reviewed
Nov 7, 2023
ngoldbaum
reviewed
Nov 8, 2023
Member
ngoldbaum
left a comment
ngoldbaum
left a comment
There was a problem hiding this comment.
Just a language tweak for the release note
Member
|
Looks good to me. Since this has only been open for two days and it's adding new things to the public API I'm going to wait until next week to merge this. In the meantime if anyone has any issues with adding these new aliases please let us know. |
mtsokol
force-pushed
the
array-api-aliases
branch
from
1c0f23e to
9e04686
Compare
mtsokol
changed the title
mtsokol
force-pushed
the
array-api-aliases
branch
from
4a97c44 to
f4be2ee
Compare
mtsokol
force-pushed
the
array-api-aliases
branch
2 times, most recently
from
84a5b5a to
c6c5c7a
Compare
Member
|
This one has conflicts too! Sorry about not merging this in timely manner like I said I would a month ago. |
mtsokol
force-pushed
the
array-api-aliases
branch
2 times, most recently
from
3236f0f to
7b077e2
Compare
Member
Author
|
I rebased it, now CI is green! |
Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com> Co-authored-by: Nathan Goldbaum <nathan.goldbaum@gmail.com>
mtsokol
force-pushed
the
array-api-aliases
branch
from
7b077e2 to
0c3cad6
Compare
Member
|
OK, let's pull this one in next. Thanks @mtsokol! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @rgommers @ngoldbaum,
This PR adds Array API compatible functions that are direct aliases of existing functions:
acos, acosh, asin, asinh, atan, atanh, atan2bitwise_left_shift, bitwise_invert, bitwise_right_shifttensordot, matmulconcat, permute_dims, powTracking issue: #25076