Conversation
Member
Author
|
@paescuj I see you've been reviewing a few PRs, wanna give this one a sanity check? |
- Use local imports (instead of globals) for `vi` APIs This is the default, it is a bit more explicit and requires less config. - Disable watch mode and coverage reports by default for CLI Watch mode wasn't enabled before with Jest either and coverage is primarily for CI. Both can be individually enabled via command line arguments (--watch, --coverage) when required locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I overall like vitest more, however, the main motivation to replace it is that it'll have better ESM support 🙂
The fact that it still only has experimental support for ESM is sad.
Most changes in the PR come from changing
{jest -> vi}.fn().