Merged
Conversation
Collaborator
Author
|
The tests were failing because of the But it looking it up, it seems the mamba solver is now used by conda: https://github.com/conda-forge/miniforge?tab=readme-ov-file#whats-the-difference-between-mambaforge-and-miniforge. So we should update https://github.com/openwpm/OpenWPM?tab=readme-ov-file#pre-requisites and the install files to revert back to the latest miniforge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few notes:
--forcewhich will overwrite. I'm not sure if this is a platform difference?storage_watchdog.pyover to python native code. Let's avoid subprocess calls out to system utilities as much as possible. MacOS has independent implementations of the OS utils, often with different options. I was tempted to installgnu-coreutilsto fix this, but I'd rather not add another dependency when we can easily do the same calculation in python.