Link expiration date in webUI Shared by Link is one day too short

[phil-davis]

Steps to reproduce

1. make a public link that expires today (that means the end of today)
   2.make a public link that expires tomorrow (that means the end of tomorrrow)
2. browse to "Shared by link"

Expected behaviour

The link at point (1) should expire "in 10 hours" (not "14 hours ago")
The link at point (2) should expire in 1 day and 10 hours (whatever text the system generates for that - it might just say "1 day")

Actual behaviour

Server configuration

Current core master.

This happens because the API returns just the expiration date with a "zero" time 00:00:00. Because of backward-compatibility issues we could not fix that at the API level. So clients (like the webUI here) need to understand that the link is valid right up to and including 23:59:59 on the expiry day.

Please also have a look around the webUI code to see where else the expiration date is rendered in a way includes the time in the calculation. Any such places are likely to have a similar off-by-one-day error.

[phil-davis]

@janackermann here is another silly little thing that I noticed when testing #39232 - maybe it is easy to fix?

[AlexAndBear]

🤕
FYI @JammingBen