Skip to content

Conversation

@DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Jan 24, 2018

backport of #30258

fixes #30246

Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
Copy link
Contributor

Stuck in the Travis queue...

@PVince81
Copy link
Contributor

@DeepDiver1975 please backport to hotfix-10.0.6 branch tomorrow. Hopefully Travis will have delivered results until then.

@codecov
Copy link

codecov bot commented Jan 24, 2018

Codecov Report

Merging #30259 into stable10 will increase coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #30259      +/-   ##
==============================================
+ Coverage       58.76%   59.07%   +0.31%     
  Complexity      18123    18123              
==============================================
  Files            1068     1068              
  Lines           62302    62334      +32     
==============================================
+ Hits            36610    36823     +213     
+ Misses          25692    25511     -181
Impacted Files Coverage Δ Complexity Δ
drone/src/lib/private/DB/OCSqlitePlatform.php 66.66% <0%> (-33.34%) 5% <0%> (ø)
drone/src/lib/private/DB/SQLiteMigrator.php 71.42% <0%> (-28.58%) 7% <0%> (ø)
drone/src/lib/private/DB/SQLiteSessionInit.php 75% <0%> (-25%) 4% <0%> (ø)
...one/src/lib/private/Repair/SqliteAutoincrement.php 63.88% <0%> (-24.58%) 9% <0%> (ø)
drone/src/lib/private/DB/AdapterSqlite.php 67.56% <0%> (-18.64%) 7% <0%> (ø)
drone/src/lib/private/Server.php 82.69% <0%> (+0.14%) 129% <0%> (ø) ⬇️
...lib/private/Repair/RepairMismatchFileCachePath.php 82.52% <0%> (+0.4%) 48% <0%> (ø) ⬇️
...e/src/lib/private/DB/QueryBuilder/QueryBuilder.php 90.74% <0%> (+0.46%) 68% <0%> (ø) ⬇️
drone/src/lib/private/DB/Connection.php 68.38% <0%> (+4.41%) 49% <0%> (ø) ⬇️
drone/src/lib/private/DB/MDB2SchemaManager.php 85.96% <0%> (+5.26%) 17% <0%> (ø) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8934738...62c6e29. Read the comment docs.

@phil-davis phil-davis merged commit 5ca9ddb into stable10 Jan 25, 2018
@phil-davis phil-davis deleted the stable10-explicit-require-symfony-translation branch January 25, 2018 01:51
@phil-davis
Copy link
Contributor

See #30265 for backport to hotfix-10.0.6

@lock
Copy link

lock bot commented Aug 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants