Skip to content

Conversation

@phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Nov 22, 2019

Reverts #36326

This let's us back-up a step of code and try again at the initial problem of issue #36266

See PR #36462 for a possible thing to do next in working-around the test fail on multi-bucket object storage.

@phil-davis
Copy link
Contributor Author

The problem with reverting this is that it fixed a different test fail.
https://drone.owncloud.com/owncloud/files_primary_s3/1296/3/7

There was 1 failure:

1) OCA\Files\Tests\Command\TransferOwnershipTest::testTransferAllFiles
Failed asserting that actual size 3 matches expected size 0.

/var/www/owncloud/server/apps/files/tests/Command/TransferOwnershipTest.php:180

So if we do this revert then we get back the original problem that was reported in #36266 (comment)

@micbar @jvillafanez @karakayasemi

@codecov
Copy link

codecov bot commented Nov 22, 2019

Codecov Report

Merging #36460 into master will increase coverage by 0.01%.
The diff coverage is 90.9%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #36460      +/-   ##
============================================
+ Coverage     65.16%   65.18%   +0.01%     
+ Complexity    19802    19792      -10     
============================================
  Files          1271     1271              
  Lines         74760    74729      -31     
  Branches       1309     1309              
============================================
- Hits          48719    48712       -7     
+ Misses        25655    25631      -24     
  Partials        386      386
Flag Coverage Δ Complexity Δ
#javascript 54% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.41% <90.9%> (+0.02%) 19792 <0> (-10) ⬇️
Impacted Files Coverage Δ Complexity Δ
...b/private/Files/ObjectStore/ObjectStoreStorage.php 83.78% <90.9%> (+6.54%) 95 <0> (-10) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92ea4da...220837e. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants