-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Update appinfo cache only if the app version is newer #39108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
There are no clear steps to reproduce the original problem, so it's difficult to foresee if this PR will fix the issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plus changelog, then LGTM. Hopefully it fixes the issue. But it's a good thing either way.
623c2b7 to
ea07549
Compare
|
Kudos, SonarCloud Quality Gate passed! |
VicDeo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to go
|
cannot reproduce the issue now, but the changes look indeed very promising. Thanks for the hard digging! |








Description
Cache app info for the appid only if the version is newer.
Related Issue
#38549
Motivation and Context
If there are multiple versions of the same app in different locations, we're expected to use the one with the latest version.
Note that the problem happens having a local cache active.
How Has This Been Tested?
occ market:upgrade <app>There is no problem with the upgrade. The installed version in the DB is the latest one (downloaded from the market). Reloading the page doesn't trigger the "update needed" page.
Screenshots (if appropriate):
Types of changes
Checklist: