Skip to content

Mobile view -> files -> Shared by link -> hide expiration date column #39232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AlexAndBear merged 2 commits into from
Sep 15, 2021
Merged

Mobile view -> files -> Shared by link -> hide expiration date column #39232

AlexAndBear merged 2 commits into from
Sep 15, 2021

Conversation

@AlexAndBear
Copy link

@AlexAndBear AlexAndBear commented Sep 15, 2021 •
edited
Loading

Description

Enhancement: Improve mobile view for "Shared by link" file list

With this PR, the "Expiration date" column won't be displayed in mobile view
anymore to gather space.

Screenshots (if appropriate):

Before

image

After

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@AlexAndBear AlexAndBear self-assigned this Sep 15, 2021
@owncloud owncloud deleted a comment from update-docs bot Sep 15, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 15, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

phil-davis
phil-davis approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works

@AlexAndBear AlexAndBear merged commit 7d3b297 into master Sep 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the shared-by-link-mobile-view branch September 15, 2021 07:59
@phil-davis phil-davis mentioned this pull request Sep 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phil-davis phil-davis phil-davis approved these changes

@jvillafanez jvillafanez Awaiting requested review from jvillafanez

+1 more reviewer

@JammingBen JammingBen JammingBen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@AlexAndBear AlexAndBear

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AlexAndBear @phil-davis @JammingBen