Skip to content

Add support for the x-office/drawing mimetype #39594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
phil-davis merged 3 commits into from
Dec 15, 2021
Merged

Add support for the x-office/drawing mimetype #39594

phil-davis merged 3 commits into from
Dec 15, 2021

Conversation

@JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Dec 14, 2021 •
edited
Loading

Related Issue

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@owncloud owncloud deleted a comment from update-docs bot Dec 14, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 14, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@pmaier1 pmaier1 mentioned this pull request Dec 14, 2021
Closed
30 tasks
@jvillafanez
Copy link
Member

jvillafanez commented Dec 14, 2021

Will the admins need to run any occ command in order to update the mimetype data? I guess it's run during the upgrade, but I'm not sure.

phil-davis
phil-davis approved these changes Dec 14, 2021
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me - I see the image with an odg file.

@jnweiger
Copy link
Contributor

jnweiger commented Dec 14, 2021

Cool!
Please merge into release-10.9.0 branch, I'll build RC2 with this!

@phil-davis phil-davis merged commit f1b53cc into release-10.9.0 Dec 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the issues/39593 branch December 15, 2021 03:36
@JammingBen JammingBen mentioned this pull request Dec 15, 2021
Closed
@jnweiger jnweiger mentioned this pull request Dec 15, 2021
Closed
@jnweiger
Copy link
Contributor

jnweiger commented Dec 15, 2021 •
edited
Loading

Confirmed fixed in 10.9.0 RC2

The Files UI requires also a new richdocuments 2.7.0 with owncloud/richdocuments#436
then the the [+] can create Diagram files too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jvillafanez jvillafanez jvillafanez approved these changes

@phil-davis phil-davis phil-davis approved these changes

@pmaier1 pmaier1 Awaiting requested review from pmaier1

Assignees

@AlexAndBear AlexAndBear

@JammingBen JammingBen

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@JammingBen @jvillafanez @jnweiger @phil-davis @AlexAndBear