Fix issue if no version has been created yet #40661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Member
Author
|
This is a bug fix for #40499, so no changelog entry needed. |
|
Kudos, SonarCloud Quality Gate passed! |
IljaN
approved these changes
Feb 28, 2023
phil-davis
approved these changes
Mar 1, 2023
jnweiger
added a commit
that referenced
this pull request
Mar 13, 2023
* prepare 10.12 * update translations * Allow stream wrappers not to provide the underlying stream (#40659) This is mainly for streams that don't wrap another one, or use a stream not provided by the native fopen function such as smbclient_open * Fix issue if no version has been created yet (#40661) * fix link in changelog. * Revert .htaccess change * OCM via ScienceMesh Signed-off-by: Michiel de Jong <[email protected]> * Get plugin from \OC::$server->query() * Improve changelog entry Signed-off-by: Michiel de Jong <[email protected]> * improve changelog entry Signed-off-by: Michiel de Jong <[email protected]> * Whitespace change to re-trigger CI Signed-off-by: Michiel de Jong <[email protected]> * Upgrading phpseclib/phpseclib (3.0.18 => 3.0.19) * changelog for phpseclib 3.0.19 * Add test for the new feature * revert logic to expose free_space, but keep availableStorage config * Make sender display name in mail notifications configurable (#40671) * [tx] updated from transifex * [tx] updated from transifex * make getFrom configurable * fix style * Adjust unit tests for MailNotificationsTest * add changelog * Document remove_sender_display_name system setting * Add unit test cases for when remove_sender_display_name is set to true --------- Co-authored-by: ownClouders <[email protected]> Co-authored-by: Phil Davis <[email protected]> * removing double to * prepare 10.12.0 RC3 * Bump final 10.12.0 version in version.php --------- Signed-off-by: Michiel de Jong <[email protected]> Co-authored-by: Juergen Weigert <[email protected]> Co-authored-by: Juan Pablo Villafañez <[email protected]> Co-authored-by: Michiel de Jong <[email protected]> Co-authored-by: Piotr Mrówczyński <[email protected]> Co-authored-by: Pasquale Tripodi <[email protected]> Co-authored-by: ownClouders <[email protected]> Co-authored-by: EParzefall <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NOTE: This PR targets the release branch.
Removing files triggers an error if no version has been created yet
This is likely to be caused by #40499 . The behavior of the feature should be safe without this patch (there are checks in place in case the directory can't be opened), but the log can be annoying.
Related Issue
No issue opened yet. Seen in 10.12 rc
Motivation and Context
The error happens every time a file is deleted.
How Has This Been Tested?
Manually tested
The error appears in the log.
Also tested with an external directory.
Screenshots (if appropriate):
Types of changes
Checklist: