fix: maximum image dimensions on preview generation and avatar upload #41175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
jvillafanez
reviewed
Feb 5, 2024
core/Controller/AvatarController.php
Outdated
| $image = new \OC_Image(); | ||
| $image->load($handle); | ||
| $image->fixOrientation(); | ||
| // don't generate previews on images with too big dimensions |
Member
There was a problem hiding this comment.
Comment needs adjustment: this is avatar upload, not preview generation
Member
|
I guess we don't really want a migration in order to homogenize the avatars because it will be expensive. Any alternative or workaround? |
Member
Author
No - the issue is only during generating as far as I can say. |
DeepDiver1975
force-pushed
the
fix/pixel-flood
branch
from
7768dff to
83b4641
Compare
|
phil-davis
approved these changes
Feb 5, 2024
jvillafanez
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: