Skip to content

Conversation

@JP-Ellis
Copy link
Contributor

@JP-Ellis JP-Ellis commented Sep 20, 2024

📝 Summary

With the release of Python 3.13 and Python 3.8 no longer being maintained, we update the supported Python versions of Pact Python to match what is currently maintained.

🚨 Breaking Changes

Python 3.8 support is dropped

🔥 Motivation

To keep align with the supported versions of Python

🔨 Test Plan

CI

🔗 Related issues/PRs

None

@JP-Ellis JP-Ellis self-assigned this Sep 20, 2024
@JP-Ellis JP-Ellis marked this pull request as draft September 20, 2024 00:39
@JP-Ellis JP-Ellis mentioned this pull request Oct 2, 2024
@JP-Ellis JP-Ellis force-pushed the chore/drop-python-38 branch from 4202672 to 55e7ab1 Compare October 7, 2024 23:57
@JP-Ellis JP-Ellis marked this pull request as ready for review October 7, 2024 23:58
@JP-Ellis
Copy link
Contributor Author

JP-Ellis commented Oct 8, 2024

This should be ready to merge as soon as the actions/setup-python action supports 3.13 (which is actually done through the data stored in the versions-manifest.json)

@JP-Ellis JP-Ellis force-pushed the chore/drop-python-38 branch from 55e7ab1 to 4d05325 Compare October 9, 2024 22:19
@codecov
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78%. Comparing base (d582e4b) to head (7e39fcc).
Report is 1 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff          @@
##           master   #796   +/-   ##
=====================================
- Coverage      78%    78%   -1%     
=====================================
  Files          30     30           
  Lines        3366   3365    -1     
=====================================
- Hits         2636   2634    -2     
- Misses        730    731    +1     
Flag Coverage Δ
examples 59% <100%> (-1%) ⬇️
tests 75% <100%> (-1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JP-Ellis JP-Ellis force-pushed the chore/drop-python-38 branch 3 times, most recently from bff4ff2 to f2111c2 Compare October 9, 2024 23:44
With the release of Python 3.13 and Python 3.8 no longer being
maintained, we update the supported Python versions of Pact Python to
match what is currently maintained.

BREAKING CHANGE: Python 3.8 support dropped

Signed-off-by: JP-Ellis <[email protected]>
@JP-Ellis JP-Ellis force-pushed the chore/drop-python-38 branch from f2111c2 to 7e39fcc Compare October 9, 2024 23:46
@JP-Ellis JP-Ellis changed the title chore!: drop python 3.8 feat!: add Python 3.13, drop 3.8 Oct 9, 2024
@JP-Ellis JP-Ellis merged commit 393190b into master Oct 9, 2024
@JP-Ellis JP-Ellis deleted the chore/drop-python-38 branch October 9, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants