This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Refactor Beefy MMR and remove parachain specific implementations#10664
Merged
paritytech-processbot[bot] merged 15 commits intoparitytech:masterfrom Apr 1, 2022
Merged
Conversation
seunlanlege
reviewed
Jan 14, 2022
Contributor
Author
|
Polkadot companion has been updated, CI checks need to be restarted |
acatangiu
reviewed
Jan 24, 2022
acatangiu
approved these changes
Jan 24, 2022
Contributor
acatangiu
left a comment
acatangiu
left a comment
There was a problem hiding this comment.
Otherwise, the code looks good, the leaf data is now generic 💯
acatangiu
added
A0-please_review
acatangiu
force-pushed
the
david/refactor-beefy-mmr
branch
from
86d7912 to
488660d
Compare
|
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
A5-stale
Contributor
|
Bump |
stale
bot
removed
the
A5-stale
|
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
A5-stale
Contributor
|
bump |
stale
bot
removed
the
A5-stale
svyatonik
approved these changes
Mar 30, 2022
Contributor
svyatonik
left a comment
svyatonik
left a comment
There was a problem hiding this comment.
LGMT. Have a couple of questions, though
Co-authored-by: Adrian Catangiu <adrian@parity.io>
Wizdave97
force-pushed
the
david/refactor-beefy-mmr
branch
from
257ebda to
c0c05b6
Compare
Wizdave97
commented
Mar 31, 2022
acatangiu
approved these changes
Mar 31, 2022
acatangiu
reviewed
Mar 31, 2022
…rate into david/refactor-beefy-mmr
Contributor
|
@Wizdave97 |
…efactor-beefy-mmr
acatangiu
reviewed
Apr 1, 2022
Contributor
|
bot merge |
DaviRain-Su
pushed a commit
to octopus-network/substrate
that referenced
this pull request
Aug 23, 2022
…itytech#10664) * refactor beefy mmr * use plain vector of bytes for leaf extra * update comment * update comments * remove unused vars * Use sp_std::vec::Vec Co-authored-by: Adrian Catangiu <adrian@parity.io> * make extra data generic * fix tests * refactor beefy-mmr * Update frame/beefy-mmr/src/lib.rs * minor fix * fmt * Update frame/beefy-mmr/src/lib.rs Co-authored-by: Adrian Catangiu <adrian@parity.io>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
…itytech#10664) * refactor beefy mmr * use plain vector of bytes for leaf extra * update comment * update comments * remove unused vars * Use sp_std::vec::Vec Co-authored-by: Adrian Catangiu <adrian@parity.io> * make extra data generic * fix tests * refactor beefy-mmr * Update frame/beefy-mmr/src/lib.rs * minor fix * fmt * Update frame/beefy-mmr/src/lib.rs Co-authored-by: Adrian Catangiu <adrian@parity.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes paritytech/grandpa-bridge-gadget#298
polkadot companion: paritytech/polkadot#4719