contracts: add seal_code_hash and seal_own_code_hash to API#10933
contracts: add seal_code_hash and seal_own_code_hash to API#10933paritytech-processbot[bot] merged 28 commits intomasterfrom
seal_code_hash and seal_own_code_hash to API#10933Conversation
|
Sorry for taking so long with my review. Kind of swamped here. Most of this is very minor stuff except the benchmarks. |
Co-authored-by: Alexander Theißen <[email protected]>
Co-authored-by: Alexander Theißen <[email protected]>
Co-authored-by: Alexander Theißen <[email protected]>
athei
left a comment
There was a problem hiding this comment.
Well done. We need to work for the benchmarking bot to work again, though.
|
/benchmark runtime pallet pallet_contracts |
|
Benchmark Runtime Pallet for branch "code_hash" with command cargo run --quiet --profile=production --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_contracts --extrinsic="*" --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/contracts/src/weights.rs --template=./.maintain/frame-weight-template.hbs Toolchain: stable-x86_64-unknown-linux-gnu (default) Results |
…--manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_contracts --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/contracts/src/weights.rs --template=./.maintain/frame-weight-template.hbs
|
So I'm not convinced we need If you go through that thread you'll see that there's a common use case that pops up for Unless we get user requests with compelling use cases for |
|
Yeah I tend to agree. @agryaznov can you remove |
seal_origin(), seal_code_hash and seal_own_code_hash to APIseal_code_hash and seal_own_code_hash to API
|
CI not happy. Try to merge master again. |
|
bot merge |
|
Hey, do you have an idea why i do not have access to the "code_hash" function inside "ink_env"? |
|
It was just merged to ink! and is not part of 3.0.1. You need to wait for the next release or use master. |
…tytech#10933) * `seal_origin` + tests added * `seal_origin` benchmark added * `seal_code_hash` + tests added * `seal_code_hash` benchmark added * `seal_own_code_hash` + tests added * `seal_own_code_hash` benchmark added * fmt lil fix * akward accident bug fix * Apply suggestions from code review Co-authored-by: Alexander Theißen <[email protected]> * Apply suggestions from code review Co-authored-by: Alexander Theißen <[email protected]> * benchmark fix * `WasmModule::getter()` to take `module_name` arg * test enhanced * fixes based on review feedback * Apply suggestions from code review Co-authored-by: Alexander Theißen <[email protected]> * Hash left as const to return a ref to it from mock * HASH test val to local const in mock * Apply suggestions from code review Co-authored-by: Alexander Theißen <[email protected]> * fixes to benchmarks according to review feedback * cargo run --quiet --profile=production --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_contracts --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/contracts/src/weights.rs --template=./.maintain/frame-weight-template.hbs * removed `seal_origin` from API Co-authored-by: Alexander Theißen <[email protected]> Co-authored-by: Parity Bot <[email protected]>
…tytech#10933) * `seal_origin` + tests added * `seal_origin` benchmark added * `seal_code_hash` + tests added * `seal_code_hash` benchmark added * `seal_own_code_hash` + tests added * `seal_own_code_hash` benchmark added * fmt lil fix * akward accident bug fix * Apply suggestions from code review Co-authored-by: Alexander Theißen <[email protected]> * Apply suggestions from code review Co-authored-by: Alexander Theißen <[email protected]> * benchmark fix * `WasmModule::getter()` to take `module_name` arg * test enhanced * fixes based on review feedback * Apply suggestions from code review Co-authored-by: Alexander Theißen <[email protected]> * Hash left as const to return a ref to it from mock * HASH test val to local const in mock * Apply suggestions from code review Co-authored-by: Alexander Theißen <[email protected]> * fixes to benchmarks according to review feedback * cargo run --quiet --profile=production --features=runtime-benchmarks --manifest-path=bin/node/cli/Cargo.toml -- benchmark --chain=dev --steps=50 --repeat=20 --pallet=pallet_contracts --extrinsic=* --execution=wasm --wasm-execution=compiled --heap-pages=4096 --output=./frame/contracts/src/weights.rs --template=./.maintain/frame-weight-template.hbs * removed `seal_origin` from API Co-authored-by: Alexander Theißen <[email protected]> Co-authored-by: Parity Bot <[email protected]>
This is a follow-up to #10789 to add the following functions to contracts API:
Edit:
seal_originwas ultimately not included in this PR, see here as to why