Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

Comments

Remove useless TryInto/TryFrom imports#11136

Merged
bkchr merged 2 commits intoparitytech:masterfrom
koushiro:remove-try-from-into
Apr 3, 2022
Merged

Remove useless TryInto/TryFrom imports#11136
bkchr merged 2 commits intoparitytech:masterfrom
koushiro:remove-try-from-into

Conversation

@koushiro
Copy link
Contributor

@koushiro koushiro commented Mar 29, 2022 •
edited
Loading

Because TryInto/TryFrom are part of the prelude by default from edition 2021

polkadot companion: paritytech/polkadot#5218

@koushiro
Remove useless imports
a448090 
Because `TryInto`/`TryFrom` are in prelude by default from edition 2021

Signed-off-by: koushiro <koushiro.cqx@gmail.com>
@koushiro koushiro mentioned this pull request Mar 29, 2022
Merged
@koushiro koushiro changed the title Remove useless imports Remove useless TryInto/TryFrom imports Apr 2, 2022
@ggwpez ggwpez added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Apr 2, 2022
@bkchr bkchr merged commit 01a3ad6 into paritytech:master Apr 3, 2022
@koushiro koushiro deleted the remove-try-from-into branch April 4, 2022 00:01
@koushiro koushiro restored the remove-try-from-into branch April 4, 2022 00:02
@koushiro koushiro deleted the remove-try-from-into branch April 4, 2022 09:14
@athei athei mentioned this pull request Apr 4, 2022
Merged
@notlesh
Copy link
Contributor

notlesh commented Apr 27, 2022

PSA: if anyone is running into failed to resolve: use of undeclared type TryInto errors after this PR, it may be that your Cargo.toml specifies an old edition, as discussed here:

https://substrate.stackexchange.com/questions/2193/cannot-find-tryinto-compilation-error-after-it-was-pruned-from-prelude

DaviRain-Su pushed a commit to octopus-network/substrate that referenced this pull request Aug 23, 2022
@koushiro @DaviRain-Su
Remove useless imports (paritytech#11136)
3888785 
Because `TryInto`/`TryFrom` are in prelude by default from edition 2021

Signed-off-by: koushiro <koushiro.cqx@gmail.com>
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@koushiro @ark0f
Remove useless imports (paritytech#11136)
343222b 
Because `TryInto`/`TryFrom` are in prelude by default from edition 2021

Signed-off-by: koushiro <koushiro.cqx@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@acatangiu acatangiu Awaiting requested review from acatangiu

@sorpaas sorpaas Awaiting requested review from sorpaas

@andresilva andresilva Awaiting requested review from andresilva

3 more reviewers

@athei athei athei approved these changes

@kianenigma kianenigma kianenigma approved these changes

@bkchr bkchr bkchr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@koushiro @notlesh @athei @kianenigma @bkchr @ggwpez