This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Properly log sealing and the newly created proposal hash from aura#1397
Merged
Properly log sealing and the newly created proposal hash from aura#1397
Conversation
gnunicorn
added
A0-please_review
gavofyork
reviewed
Jan 11, 2019
core/consensus/aura/src/lib.rs
Outdated
| ); | ||
|
|
||
| let import_block = ImportBlock { | ||
| let import_block : ImportBlock<B> = ImportBlock { |
Member
There was a problem hiding this comment.
style:
Suggested change
| let import_block : ImportBlock<B> = ImportBlock { | |
| let import_block: ImportBlock<B> = ImportBlock { |
gavofyork
approved these changes
Jan 11, 2019
gavofyork
approved these changes
Jan 11, 2019
gnunicorn
added a commit
to paritytech/polkadot
that referenced
this pull request
Jan 14, 2019
in accordance with paritytech/substrate#1397
rphmeier
pushed a commit
to paritytech/polkadot
that referenced
this pull request
Jan 15, 2019
in accordance with paritytech/substrate#1397
MTDK1
pushed a commit
to bdevux/substrate
that referenced
this pull request
Apr 12, 2019
…aritytech#1397) * Properly log sealing and the newly created proposal hash from aura * Update lib.rs
liuchengxu
added a commit
to liuchengxu/substrate
that referenced
this pull request
May 31, 2023
…saction-proof Refactor subspace-fraud-proof
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1138.
I opted for keeping the mentioned message but rephrase it slightly, because it still contains other useful information and is a good default in non-aura cases. Instead I added another message post pre-sealing in aura to announce the hash change, that felt more explicit and cleaner to me.
Run with
RUST_LOG=info nodenow announces them as: