This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Use #[panic_implementation] attribute that was landed in the recent nightly#199
Merged
Use #[panic_implementation] attribute that was landed in the recent nightly#199
Conversation
gavofyork
approved these changes
Jun 4, 2018
gavofyork
reviewed
Jun 4, 2018
| #[panic_implementation] | ||
| #[no_mangle] | ||
| pub extern fn panic_fmt(_fmt: ::core::fmt::Arguments, _file: &'static str, _line: u32, _col: u32) { | ||
| pub fn rust_begin_panic(info: &::core::panic::PanicInfo) -> ! { |
Member
There was a problem hiding this comment.
slightly bikeshedding (so won't block approval) but i prefer simple names if possible - this could be simply panic like before. also, anything with begin in its names instinctively makes me look for something with similar with end in its name.
Contributor
Author
There was a problem hiding this comment.
Agree. Sneaked rename to panic into paritytech/polkadot#189.
gavofyork
approved these changes
Jun 4, 2018
gavofyork
added
A8-looksgood
and removed
A0-please_review
JoshOrndorff
pushed a commit
to moonbeam-foundation/substrate
that referenced
this pull request
Apr 21, 2021
liuchengxu
pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
liuchengxu
pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
liuchengxu
added a commit
to autonomys/substrate
that referenced
this pull request
Jun 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should fix the travis build