This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Conversation
This was referenced Jun 26, 2018
Contributor
Author
|
deadlock is fixed in #260 |
pepyakin
reviewed
Jun 28, 2018
|
|
||
| /// Check execution proof, generated by `prove` call. | ||
| pub fn proof_check<Exec: CodeExecutor>( | ||
| pub fn execution_proof_check<Exec: CodeExecutor>( |
Contributor
There was a problem hiding this comment.
in comment: generated by prove_execution call
pepyakin
reviewed
Jun 28, 2018
substrate/client/src/in_mem.rs
Outdated
| best_number: Zero::zero(), | ||
| genesis_hash: Default::default(), | ||
| }) | ||
| storage: storage.clone(), |
Contributor
There was a problem hiding this comment.
Is this clone really needed?
Contributor
Author
There was a problem hiding this comment.
Not in this PR :) It is actually from the next PR (https://github.com/paritytech/polkadot/pull/251/files#diff-8f118ee188780f9183b6af320625cfb9R106)
| blockchain: Arc<Blockchain<S, F>>, | ||
| } | ||
|
|
||
| /// Ligh block (header and justification) import operation. |
gavofyork
added
A8-looksgood
and removed
A0-please_review
gavofyork
approved these changes
Jun 29, 2018
Member
gavofyork
left a comment
gavofyork
left a comment
There was a problem hiding this comment.
Only a shallow review but looks good.
gavofyork
approved these changes
Jun 29, 2018
JoshOrndorff
added a commit
to moonbeam-foundation/substrate
that referenced
this pull request
Apr 21, 2021
* Remove mock timestamp provider. * Relax runtime's minimum timestamp requirement. (We aren't using time-based slots, so it doesn't matter.) * bump runtime version
liuchengxu
pushed a commit
to chainx-org/substrate
that referenced
this pull request
Aug 23, 2021
provide new fee proportion
liuchengxu
added a commit
to autonomys/substrate
that referenced
this pull request
Jun 3, 2022
Make the fraud proof report actually work
helin6
pushed a commit
to boolnetwork/substrate
that referenced
this pull request
Jul 25, 2023
* return none if subscription returns early Signed-off-by: Gregory Hill <gregorydhill@outlook.com> * add comment on subscription close Signed-off-by: Gregory Hill <gregorydhill@outlook.com> * no need for jsonrpsee error enum Signed-off-by: Gregory Hill <gregorydhill@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is about switch from using in-memory to database backend on light nodes. Additionally,
client/src/light.rshas been split into separate files inclient/src/light/subfolder, because it grew too big.Databases of full && light nodes are made incompatible (i.e. you can't open full db by light client and light db by full client). Initially tried to use the same db for both nodes, but found this a bad decision, because it:
P.S.: syncing with
--lightis broken on current master, I'm currently working on it, but still wanted to start reviews of my previous work.