This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Fetching storage proofs by light client#252
Merged
Conversation
svyatonik
force-pushed
the
light_storage_proof
branch
from
161b953 to
c6ebffb
Compare
Member
|
[clabot:check] |
|
It looks like @svyatonik signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
This was referenced Aug 8, 2018
pepyakin
approved these changes
Aug 8, 2018
| let remote_block_id = BlockId::Number(0); | ||
| let remote_block_hash = remote_client.block_hash(0).unwrap().unwrap(); | ||
| let mut remote_block_header = remote_client.header(&remote_block_id).unwrap().unwrap(); | ||
| remote_block_header.state_root = remote_client.state_at(&remote_block_id).unwrap().storage_root(::std::iter::empty()).0.into(); |
substrate/state-machine/src/lib.rs
Outdated
| let result = proving_backend.storage(key).map_err(|e| Box::new(e) as Box<Error>)?; | ||
| Ok((result, proving_backend.extract_proof())) | ||
| } | ||
| /// Check storage read proof, generated by `prove` call. |
Contributor
There was a problem hiding this comment.
do you mean "generated by prove_read call"? : )
pepyakin
added
A8-looksgood
and removed
A0-please_review
rphmeier
reviewed
Aug 8, 2018
| request: &RemoteReadRequest<Block::Hash>, | ||
| remote_proof: Vec<Vec<u8>> | ||
| ) -> ClientResult<Option<Vec<u8>>> { | ||
| let local_header = self.blockchain.header(BlockId::Hash(request.block))?; |
Contributor
There was a problem hiding this comment.
since this happens well beyond the point where the storage request is actually issued, could the header be pruned if it takes a long time to serve the request or if the header was on the verge of being pruned when the request was issued?
svyatonik
added
A0-please_review
gavofyork
reviewed
Aug 12, 2018
substrate/state-machine/src/lib.rs
Outdated
| let result = proving_backend.storage(key).map_err(|e| Box::new(e) as Box<Error>)?; | ||
| Ok((result, proving_backend.extract_proof())) | ||
| } | ||
| /// Check storage read proof, generated by `prove_read` call. |
gavofyork
approved these changes
Aug 12, 2018
dvdplm
added a commit
that referenced
this pull request
Aug 14, 2018
* master: Less verbosity (#546) Fetching storage proofs by light client (#252) Gitlab CI build file for linux. (#552) Vote out offline authorities (#524) fix block body fetch for availability pruning (#539) Continue sync after ancestry search (#538) Docs Typo Fixes (#534) don't wait for all futures to resolve before shutdown (#536) Update libp2p and some log (#532) Mh public key for telemetry (#526) Td bps (#527) Reserved peers CLI flag (#528)
pepyakin
pushed a commit
that referenced
this pull request
Aug 24, 2018
* storage proofs * fixed grumbles * Update lib.rs
JoshOrndorff
pushed a commit
to moonbeam-foundation/substrate
that referenced
this pull request
Apr 21, 2021
liuchengxu
pushed a commit
to autonomys/substrate
that referenced
this pull request
Jun 3, 2022
…ossipsub Subspace networking (gossipsub)
helin6
pushed a commit
to boolnetwork/substrate
that referenced
this pull request
Jul 25, 2023
* Move tests to module in own file * Add test-node-proc crate * Move test node to main lib, fix compilation errors * Fmt * Attempted port scanning * Use global static port to allocate open ports * Register missing type sizes * Fix port scanning and balances test * Don't wait for blocks on insert_jey test * Fmt * Remove unused dependencies * Download v3.0.0 rust binary * Move substrate bin to home dir * Add test instructions to README * Figure out the $PATH * Remove path echo * Add check for missing substrate binary on the PATH * @niklasad1 review: don't include client feature for tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.