This repository was archived by the owner on Nov 15, 2023. It is now read-only.
[WIP] Display for Address/AccountId/AccountIndex #591
Closed
Dylan-DPC-zz wants to merge 4 commits intoparitytech:masterfrom
Dylan-DPC-zz:feature/display
Closed
[WIP] Display for Address/AccountId/AccountIndex #591Dylan-DPC-zz wants to merge 4 commits intoparitytech:masterfrom Dylan-DPC-zz:feature/display
Dylan-DPC-zz wants to merge 4 commits intoparitytech:masterfrom
Dylan-DPC-zz:feature/display
Conversation
move base58 to a separate file add byte-num and base58 dependencies
rphmeier
suggested changes
Aug 23, 2018
Contributor
rphmeier
left a comment
rphmeier
left a comment
There was a problem hiding this comment.
A couple grumbles:
- SS58 is a bit different than regular base58. Check out the
ed25519crate and theto_ss58checkmethod. - Substrate runtime components should bound simply by
Display, and the implementations should do the ss58check internally. This might require a PR in https://github.com/paritytech/polkadot now that we've split the projects. - Tabs, not spaces.
- Formatting: a lot of extraneous spaces in the code
Dylan-DPC-zz
changed the title
Author
|
Notes:
|
gavofyork
added
A1-onice
A5-stale
Member
|
pretty stale now - if interesting in continuing on this please reopen for guidance. |
lamafab
pushed a commit
to lamafab/substrate
that referenced
this pull request
Jun 16, 2020
…ritytech#598) * Update Substrate after repository reorganisation * Switch back to polkadot-master * Bump `bitvec` and `parity-scale-codec` (paritytech#591) Also bump other dependencies, but respect semver on them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #213
Added Base58 as a dependency to this sub-crate
Since Base58 only accepts a
[u8]orstr, added a trait that needs the type to be implemented on to be convertable to a vector.