This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Conversation
arkpar
approved these changes
Sep 10, 2018
pepyakin
approved these changes
Sep 10, 2018
Contributor
pepyakin
left a comment
pepyakin
left a comment
There was a problem hiding this comment.
Looks good, one minor naming nit
| Tabled(PropIndex, Balance, Vec<AccountId>), | ||
| Started(ReferendumIndex, VoteThreshold), | ||
| Passed(ReferendumIndex), | ||
| Failed(ReferendumIndex), |
Contributor
There was a problem hiding this comment.
Can we come up with a different name for this case? This introduces some ambiguity with the result of dispatching the proposal. Is there a special word in English for an unsuccessful vote?
Contributor
There was a problem hiding this comment.
how about?
NotPassedKeepStatusQuo
pepyakin
added
A8-looksgood
and removed
A0-please_review
12 tasks
helin6
pushed a commit
to boolnetwork/substrate
that referenced
this pull request
Jul 25, 2023
* Add getters for `Module` * Return `Iterator` instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #696