Conversation
dvdplm
commented
Sep 23, 2020
| } | ||
|
|
||
| #[cfg(test)] | ||
| #[cfg(feature = "integration-tests")] |
Contributor
Author
There was a problem hiding this comment.
All tests in this module are integration tests so cargo check --tests will warn about unused items without this.
Contributor
There was a problem hiding this comment.
Means the individual test ones are redundant now, but anyway I'll fix that in #165
Closed
Sort out the RefCount type (ty @dvc94ch) Random tweaks to make test-node more similar to the vanilla node-template
Merged
dvdplm
commented
Sep 24, 2020
|
|
||
| /// Type used to encode the number of references an account has. | ||
| pub type RefCount = u8; | ||
| pub type RefCount = u32; |
Contributor
Author
There was a problem hiding this comment.
@dvc94ch ty! Was scratching my head on this one. :)
ascjones
approved these changes
Sep 24, 2020
| } | ||
|
|
||
| #[cfg(test)] | ||
| #[cfg(feature = "integration-tests")] |
Contributor
There was a problem hiding this comment.
Means the individual test ones are redundant now, but anyway I'll fix that in #165
dvdplm
added a commit
that referenced
this pull request
Sep 24, 2020
* master: Upgrade to substrate 2.0.0 (#173)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update dependencies and sort out incompatibilities.