Skip to content

Comments

document push type and priority keys for notifications#639

Merged
TomWFox merged 4 commits intoparse-community:gh-pagesfrom
funkenstrahlen:apns-push-type
Jul 27, 2019
Merged

document push type and priority keys for notifications#639
TomWFox merged 4 commits intoparse-community:gh-pagesfrom
funkenstrahlen:apns-push-type

Conversation

@funkenstrahlen
Copy link
Contributor

@funkenstrahlen funkenstrahlen commented Jul 13, 2019

@funkenstrahlen funkenstrahlen mentioned this pull request Jul 13, 2019
Merged
davimacedo
davimacedo reviewed Jul 14, 2019
View reviewed changes
Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind to also include here?

@funkenstrahlen
Copy link
Contributor Author

funkenstrahlen commented Jul 14, 2019

Sure I can do that. Thanks for pointing this out.

@funkenstrahlen
Copy link
Contributor Author

funkenstrahlen commented Jul 14, 2019

As suggested I added the push type and priority key explanation to the JS docs as well.

@davimacedo
Copy link
Member

davimacedo commented Jul 14, 2019

@TomWFox let's wait for parse-community/parse-server-push-adapter#127 and merge.

@funkenstrahlen
Copy link
Contributor Author

funkenstrahlen commented Jul 27, 2019

This is ready to merge now as the new functionality is merged into Parse push adapter.

@TomWFox TomWFox merged commit 131698d into parse-community:gh-pages Jul 27, 2019
mtrezza added a commit to mtrezza/docs that referenced this pull request Sep 6, 2019
@mtrezza
Merge commit 'e129790ed587819ecfcaed59fc7ff90ec6ffcfa1' into gh-pages
d61b9db 
* commit 'e129790ed587819ecfcaed59fc7ff90ec6ffcfa1': (84 commits)
  Add `cascadeSave` option in ParseObject to JS docs (parse-community#664)
  Update apple sign in documentation (parse-community#662)
  Bump mixin-deep from 1.3.1 to 1.3.2 (parse-community#670)
  Update GraphQL docs with latest changes (parse-community#669)
  remove a bunch of parse cloud references (parse-community#654)
  docs: fixed examples for pipeline in aggregation (parse-community#661)
  Add beta notice to the GraphQL Guide (parse-community#659)
  iOS Documentation Revamp (parse-community#650)
  Fix doc for creating a subscription in javascript (parse-community#658)
  GraphQL Customisation (parse-community#652)
  added PhantAuth authData docs (parse-community#655)
  Fix typo in keys.md (parse-community#656)
  Fix typo in cloud-code.md (parse-community#657)
  add reference to afterFind, add more detail on predefined classes (parse-community#653)
  Add `keys` and `excludeKeys` options to REST docs (parse-community#649)
  document push type and priority keys for notifications (parse-community#639)
  Documentation for Sign In With Apple (parse-community#648)
  Documentation for isDataAvailable (parse-community#647)
  Remove line for 3.x (parse-community#646)
  Add documentation for query.withCount (parse-community#645)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davimacedo davimacedo davimacedo approved these changes

+1 more reviewer

@TomWFox TomWFox TomWFox approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@funkenstrahlen @davimacedo @TomWFox