Conversation
dplewis
approved these changes
Jun 6, 2019
Member
dplewis
left a comment
dplewis
left a comment
There was a problem hiding this comment.
LGTM! Quick question did you use npm install to generate the package-lock.json file or did you manually change the version number?
Contributor
Author
|
@dplewis I did it manually, should that be ok? |
Member
|
No idea, never done it manually. |
Contributor
Author
|
@dplewis I did so for the Parse Server release and that seemed to work fine. I guess there's only one way to find out - happy for me to merge & create the release? |
Member
|
One way to find out |
beiguancyc
pushed a commit
to beiguancyc/parse-dashboard
that referenced
this pull request
Jun 10, 2019
* commit 'ea7ab044557e2b7977092dbe7e15b9f432330d30': ⚡️ Release 1.3.3 (parse-community#1100) 1.3.2 version bump + changelog (parse-community#1099) Update Dockerfile (parse-community#1098) Update file-loader to the latest version 🚀 (parse-community#1095) Update react-router-dom to the latest version 🚀 (parse-community#1094) Update react-router to the latest version 🚀 (parse-community#1093) Update webpack to the latest version 🚀 (parse-community#1092) Update express to the latest version 🚀 (parse-community#1090) Update puppeteer to the latest version 🚀 (parse-community#1089) Update webpack to the latest version 🚀 (parse-community#1088) Update Dockerfile (parse-community#1087) Update webpack to the latest version 🚀 (parse-community#1084)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.