Conversation
Member
Author
|
@acinader Can you pull it down and see if it works? |
acinader
approved these changes
Oct 24, 2019
Contributor
acinader
left a comment
acinader
left a comment
There was a problem hiding this comment.
it works for me.
worth noting that after running npm installl, the package-lock was dirty. My assumption is that that is a due to a change in parse-server where we always get latest, so we'll see changes if there are andy dependency changes there....
Member
Author
|
I alway assumed that for parse-server for example although package.json points to the latest. package-lock should point to a specific commit (that commit will get update if you regenerate package-lock.json). |
beiguancyc
pushed a commit
to beiguancyc/parse-dashboard
that referenced
this pull request
Oct 27, 2019
* parse: ⚡️ Release v2.0.5 (parse-community#1357) # Conflicts: # package-lock.json
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Package Lock file to handle dependencies (corejs3).
CoreJS is no longer a dev dependency 👇
https://github.com/parse-community/parse-dashboard/compare/2.0.5?expand=1#diff-32607347f8126e6534ebc7ebaec4853dR917