refactor: replace create-react-class with ES6 classes#1818
Merged
mtrezza merged 5 commits intoparse-community:masterfrom Oct 4, 2021
Merged
refactor: replace create-react-class with ES6 classes#1818mtrezza merged 5 commits intoparse-community:masterfrom
mtrezza merged 5 commits intoparse-community:masterfrom
Conversation
Thanks for opening this pull request!
|
damianstasik
force-pushed
the
remove-create-react-class
branch
from
5fe55fb to
33e18d1
Compare
damianstasik
changed the title
Member
|
Nice refactor! Can you commit |
Contributor
Author
|
@dblythy |
Member
|
Is this ready for review? |
Contributor
Author
|
@mtrezza yes |
mtrezza
approved these changes
Oct 4, 2021
Member
mtrezza
left a comment
mtrezza
left a comment
There was a problem hiding this comment.
Looks good! Thanks for making Parse Dashboard 1 dependency lighter.
Contributor
|
🎉 This pull request has been released in version 3.2.0 |
beiguancyc
pushed a commit
to beiguancyc/parse-dashboard
that referenced
this pull request
Oct 9, 2021
* source: (53 commits) chore(release): 3.2.1 [skip ci] chore(release): 3.2.1-beta.1 [skip ci] ci: fix prerelease labels chore(release): 3.2.1-alpha.1 [skip ci] fix: enabling context menu for read-only cells (parse-community#1844) docs: add info about --dev parameter (parse-community#1842) build: merge beta (parse-community#1841) build: merge alpha (parse-community#1840) docs: fix release changelog filename docs: reword changelog quote docs: fix changelog branch names (parse-community#1837) refactor: simplify reading dashboard config from a json file (parse-community#1828) ci: update release branch names chore(release): 3.2.0 [skip ci] feat: add ctrl + arrow key to jump to first/last cell; fix left/right key navigation with hidden columns (parse-community#1827) refactor: upgrade inquirer from 8.1.2 to 8.1.3 (parse-community#1829) refactor: upgrade otpauth from 7.0.5 to 7.0.6 (parse-community#1830) refactor: replace create-react-class with ES6 classes (parse-community#1818) refactor: replace query-string with URLSearchParams (parse-community#1819) docs: fix typo in refactor changelog entry ... # Conflicts: # package-lock.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
Rest of the app uses ES6 classes, the last of two components that were using
create-react-classcan be safely refactored to "native" class components.Approach
TODOs before merging