refactor: use object refs instead of deprecated string refs#1866
Merged
mtrezza merged 1 commit intoparse-community:alphafrom Oct 15, 2021
Merged
refactor: use object refs instead of deprecated string refs#1866mtrezza merged 1 commit intoparse-community:alphafrom
mtrezza merged 1 commit intoparse-community:alphafrom
Conversation
Thanks for opening this pull request!
|
mtrezza
approved these changes
Oct 15, 2021
Member
mtrezza
left a comment
mtrezza
left a comment
There was a problem hiding this comment.
Looks good! Another modernization step into the future!
Member
|
@visualfanatic I thought you requested a review for this PR, but I just saw you didn't, was this ready for merge? It worked fine for me locally. |
Contributor
Author
|
@mtrezza no worries, it was ready 👍 |
Contributor
|
🎉 This pull request has been released in version 3.3.0-alpha.6 |
Contributor
|
🎉 This change has been released in version 3.3.0-beta.1 |
Contributor
|
🎉 This change has been released in version 3.3.0 |
damianstasik
pushed a commit
to damianstasik/parse-dashboard
that referenced
this pull request
Jan 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
String refs are deprecated and React team will be removing them at some point in the future. This PR refactors them into object refs using
createRef.Related issue: #1866
Approach
React.createRef,this.refsobject with class properties,ReactDOM.findDOMNodefor refs as they are unnecessary, as the ref already points to a DOM node,TODOs before merging