Skip to content

Comments

style: require new line at the end of file#1874

Merged
mtrezza merged 4 commits intoparse-community:alphafrom
damianstasik:require-new-lines
Oct 20, 2021
Merged

style: require new line at the end of file#1874
mtrezza merged 4 commits intoparse-community:alphafrom
damianstasik:require-new-lines

Conversation

@damianstasik
Copy link
Contributor

@damianstasik damianstasik commented Oct 20, 2021

New Pull Request Checklist

Issue Description

This PR adds a new rule to the ESLint config so that each file is required to end with a new line.

I also ran ESLint on all files just to make sure all files now end with a new line.

Related issue: #1870

Approach

  • Include the eol-last in the config file
  • Run ESLint on all files

TODOs before merging

  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Oct 20, 2021

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@damianstasik
Copy link
Contributor Author

damianstasik commented Oct 20, 2021

Ready for review 👍

@mtrezza
Copy link
Member

mtrezza commented Oct 20, 2021 •
edited
Loading

@visualfanatic You seem to be on an amazing PR streak today! Would you be interested in officially joining the Parse Dashboard team as a contributor? This will also make it easier for you to request reviews using the GitHub feature in the top right corner that is disabled for non-members.

@damianstasik
Copy link
Contributor Author

damianstasik commented Oct 20, 2021 •
edited
Loading

@mtrezza Thanks!

Would you be interested in officially joining the Parse Dashboard team as a contributor?

I would love to!

@mtrezza
Copy link
Member

mtrezza commented Oct 20, 2021

Great, I have opened a poll to formally propose your membership.

mtrezza
mtrezza approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza merged commit cbce861 into parse-community:alpha Oct 20, 2021
@parseplatformorg
Copy link
Contributor

parseplatformorg commented Oct 20, 2021

🎉 This pull request has been released in version 3.3.0-alpha.9

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Oct 20, 2021
@mtrezza mtrezza mentioned this pull request Oct 20, 2021
Closed
3 tasks
@snyk-bot snyk-bot mentioned this pull request Oct 31, 2021
Merged
@parseplatformorg
Copy link
Contributor

parseplatformorg commented Nov 1, 2021

🎉 This change has been released in version 3.3.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Nov 1, 2021
@parseplatformorg
Copy link
Contributor

parseplatformorg commented Jan 1, 2022

🎉 This change has been released in version 3.3.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees

No one assigned

Labels

state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@damianstasik @mtrezza @parseplatformorg @visualfanatic