Skip to content

fix: File extension is hidden in file field when editing object in modal dialog in data browser#2472

Merged
mtrezza merged 11 commits intoparse-community:alphafrom
AshishBarvaliya:bug/2470
Jun 30, 2023
Merged

fix: File extension is hidden in file field when editing object in modal dialog in data browser#2472
mtrezza merged 11 commits intoparse-community:alphafrom
AshishBarvaliya:bug/2470

Conversation

@AshishBarvaliya
Copy link
Member

@AshishBarvaliya AshishBarvaliya commented Jun 22, 2023

Closes: #2470

Approach

@parse-github-assistant
Copy link

parse-github-assistant bot commented Jun 22, 2023

Thanks for opening this pull request!

@AshishBarvaliya AshishBarvaliya changed the title fix:The file extension is hidden under the icon within the file cell fix: The file extension is hidden under the icon within the file cell Jun 22, 2023
@uffizzi-cloud
Copy link

uffizzi-cloud bot commented Jun 22, 2023

Uffizzi Ephemeral Environment deployment-29165

⌚ Updated Jun 22, 2023, 01:12 UTC

☁️ https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2472

📄 View Application Logs etc.

What is Uffizzi? Learn more

@mtrezza mtrezza closed this Jun 23, 2023
@mtrezza mtrezza reopened this Jun 23, 2023
@mtrezza mtrezza changed the title fix: The file extension is hidden under the icon within the file cell fix: File extension is hidden in file cell in data browser Jun 23, 2023
@uffizzi-cloud
Copy link

uffizzi-cloud bot commented Jun 23, 2023

Uffizzi Ephemeral Environment deployment-29341

⌚ Updated Jun 23, 2023, 23:36 UTC

☁️ https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2472

📄 View Application Logs etc.

What is Uffizzi? Learn more

@mtrezza
Copy link
Member

mtrezza commented Jun 23, 2023

Could you add a screen recording of what this PR fixes?

@AshishBarvaliya
Copy link
Member Author

AshishBarvaliya commented Jun 24, 2023

Rather than implementing changes to the common pill component to adjust the file cell styles in EditRowDialog, I have devised a new style class. This modification enhances the readability of file names along with their extensions.

Before changes -
Screenshot 2023-06-24 at 1 27 33 PM

After changes -
Screenshot 2023-06-24 at 1 25 42 PM

@mtrezza
Copy link
Member

mtrezza commented Jun 24, 2023

Which parts of the UI does this affect? Is this the "Add row with modal" dialog?

@AshishBarvaliya
Copy link
Member Author

AshishBarvaliya commented Jun 24, 2023

yes

@mtrezza mtrezza closed this Jun 24, 2023
@mtrezza mtrezza reopened this Jun 24, 2023
@uffizzi-cloud
Copy link

uffizzi-cloud bot commented Jun 24, 2023

Uffizzi Ephemeral Environment deployment-29354

⌚ Updated Jun 24, 2023, 21:01 UTC

☁️ https://app.uffizzi.com/github.com/parse-community/parse-dashboard/pull/2472

📄 View Application Logs etc.

What is Uffizzi? Learn more

@mtrezza
Copy link
Member

mtrezza commented Jun 24, 2023 •
edited
Loading

I only see en empty field when uploading a file with modal:

image

Tried in preview and locally.

@AshishBarvaliya
Copy link
Member Author

AshishBarvaliya commented Jun 24, 2023

This open PR fixes that issue : #2471 (issue: #2418 )

@mtrezza
Copy link
Member

mtrezza commented Jun 24, 2023

So we need to merge #2471 first, then this PR?

@AshishBarvaliya
Copy link
Member Author

AshishBarvaliya commented Jun 24, 2023

Save the object(row) first, and then you'll be able to view the uploaded file.

@mtrezza
Copy link
Member

mtrezza commented Jun 24, 2023 •
edited
Loading

Then I still don't fully understand what this PR fixes. Could you please upload a screen recording (not screenshot) of the bug vs. fixed?

@AshishBarvaliya
Copy link
Member Author

AshishBarvaliya commented Jun 27, 2023

Before:
CPT2306262126-1181x641

After:
CPT2306262127-1135x635

It's essentially a minor style fix where previously the file was displayed as '666162,' but after the changes, it now appears as '666162.png'.

@mtrezza
Copy link
Member

mtrezza commented Jun 30, 2023

Got it, that is when editing an existing row, I was able to duplicate that, thanks for the videos.

mtrezza
mtrezza approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested locally

@mtrezza mtrezza changed the title fix: File extension is hidden in file cell in data browser fix: File extension is hidden in file field when editing object in modal dialog in data browser Jun 30, 2023
@mtrezza mtrezza merged commit 8df4e4d into parse-community:alpha Jun 30, 2023
parseplatformorg pushed a commit that referenced this pull request Jun 30, 2023
@semantic-release-bot
chore(release): 5.2.0-alpha.26 [skip ci]
e45d7bf 
# [5.2.0-alpha.26](5.2.0-alpha.25...5.2.0-alpha.26) (2023-06-30)

### Bug Fixes

* File extension is hidden in file field when editing object in modal dialog in data browser ([#2472](#2472)) ([8df4e4d](8df4e4d))
@parseplatformorg
Copy link
Contributor

parseplatformorg commented Jun 30, 2023

🎉 This change has been released in version 5.2.0-alpha.26

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Jun 30, 2023
parseplatformorg pushed a commit that referenced this pull request Sep 15, 2023
@semantic-release-bot
chore(release): 5.3.0-beta.1 [skip ci]
77d039a 
# [5.3.0-beta.1](5.2.0...5.3.0-beta.1) (2023-09-15)

### Bug Fixes

* Adding a file when adding a new row in the data browser doesn't show filename ([#2471](#2471)) ([5bbb94e](5bbb94e))
* File extension is hidden in file field when editing object in modal dialog in data browser ([#2472](#2472)) ([8df4e4d](8df4e4d))
* Incorrect highlight maker position in class list in data browser ([#2490](#2490)) ([8c28d24](8c28d24))
* Pasting location coordinates into field of type `GeoPoint` does not work in data browser ([#2464](#2464)) ([a8ce343](a8ce343))
* Selecting a saved filter in data browser also highlights other filters with equal names ([#2466](#2466)) ([35360fe](35360fe))
* Vertical scrollbar in data browser is outside visible area when scrolling horizontally ([#2457](#2457)) ([5acac3f](5acac3f))

### Features

* Add Cloud Function execution on Parse Object in data browser ([#2409](#2409)) ([996ce91](996ce91))
* Add parameter `selectedField` to script payload to determine which object field was selected when script was invoked ([#2483](#2483)) ([e98d653](e98d653))
* Add refresh button to Cloud Config page ([#2480](#2480)) ([be212b0](be212b0))
* Add security checks page ([#2491](#2491)) ([103b9c6](103b9c6))
* Add support for confirmation dialog before script execution in data browser ([#2481](#2481)) ([64d3913](64d3913))
* Add typing with auto-complete to select a filter field in the data browser ([#2463](#2463)) ([257f76b](257f76b))
* Reopen last opened class when navigating to data browser ([#2468](#2468)) ([3d7148e](3d7148e))

### Reverts

* fix: Vertical scrollbar in data browser is outside visible area when scrolling horizontally ([#2457](#2457)) ([#2477](#2477)) ([2f1d84e](2f1d84e))
@parseplatformorg
Copy link
Contributor

parseplatformorg commented Sep 15, 2023

🎉 This change has been released in version 5.3.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Sep 15, 2023
parseplatformorg pushed a commit that referenced this pull request Sep 20, 2023
@semantic-release-bot
chore(release): 5.3.0-alpha.1 [skip ci]
86c45d8 
# [5.3.0-alpha.1](5.2.0...5.3.0-alpha.1) (2023-09-20)

### Bug Fixes

* Adding a file when adding a new row in the data browser doesn't show filename ([#2471](#2471)) ([5bbb94e](5bbb94e))
* File extension is hidden in file field when editing object in modal dialog in data browser ([#2472](#2472)) ([8df4e4d](8df4e4d))
* Incorrect highlight maker position in class list in data browser ([#2490](#2490)) ([8c28d24](8c28d24))
* Pasting location coordinates into field of type `GeoPoint` does not work in data browser ([#2464](#2464)) ([a8ce343](a8ce343))
* Selecting a saved filter in data browser also highlights other filters with equal names ([#2466](#2466)) ([35360fe](35360fe))
* Vertical scrollbar in data browser is outside visible area when scrolling horizontally ([#2457](#2457)) ([5acac3f](5acac3f))

### Features

* Add Cloud Function execution on Parse Object in data browser ([#2409](#2409)) ([996ce91](996ce91))
* Add parameter `selectedField` to script payload to determine which object field was selected when script was invoked ([#2483](#2483)) ([e98d653](e98d653))
* Add refresh button to Cloud Config page ([#2480](#2480)) ([be212b0](be212b0))
* Add security checks page ([#2491](#2491)) ([103b9c6](103b9c6))
* Add support for confirmation dialog before script execution in data browser ([#2481](#2481)) ([64d3913](64d3913))
* Add typing with auto-complete to select a filter field in the data browser ([#2463](#2463)) ([257f76b](257f76b))
* Reopen last opened class when navigating to data browser ([#2468](#2468)) ([3d7148e](3d7148e))

### Reverts

* fix: Vertical scrollbar in data browser is outside visible area when scrolling horizontally ([#2457](#2457)) ([#2477](#2477)) ([2f1d84e](2f1d84e))
@parseplatformorg
Copy link
Contributor

parseplatformorg commented Sep 20, 2023

🎉 This change has been released in version 5.3.0-alpha.1

parseplatformorg pushed a commit that referenced this pull request Nov 16, 2023
@semantic-release-bot
chore(release): 5.3.0 [skip ci]
2a90ae6 
# [5.3.0](5.2.0...5.3.0) (2023-11-16)

### Bug Fixes

* Adding a file when adding a new row in the data browser doesn't show filename ([#2471](#2471)) ([5bbb94e](5bbb94e))
* File extension is hidden in file field when editing object in modal dialog in data browser ([#2472](#2472)) ([8df4e4d](8df4e4d))
* Incorrect highlight maker position in class list in data browser ([#2490](#2490)) ([8c28d24](8c28d24))
* Pasting location coordinates into field of type `GeoPoint` does not work in data browser ([#2464](#2464)) ([a8ce343](a8ce343))
* Selecting a saved filter in data browser also highlights other filters with equal names ([#2466](#2466)) ([35360fe](35360fe))
* Vertical scrollbar in data browser is outside visible area when scrolling horizontally ([#2457](#2457)) ([5acac3f](5acac3f))

### Features

* Add Cloud Function execution on Parse Object in data browser ([#2409](#2409)) ([996ce91](996ce91))
* Add parameter `selectedField` to script payload to determine which object field was selected when script was invoked ([#2483](#2483)) ([e98d653](e98d653))
* Add refresh button to Cloud Config page ([#2480](#2480)) ([be212b0](be212b0))
* Add security checks page ([#2491](#2491)) ([103b9c6](103b9c6))
* Add support for confirmation dialog before script execution in data browser ([#2481](#2481)) ([64d3913](64d3913))
* Add typing with auto-complete to select a filter field in the data browser ([#2463](#2463)) ([257f76b](257f76b))
* Reopen last opened class when navigating to data browser ([#2468](#2468)) ([3d7148e](3d7148e))

### Reverts

* fix: Vertical scrollbar in data browser is outside visible area when scrolling horizontally ([#2457](#2457)) ([#2477](#2477)) ([2f1d84e](2f1d84e))
@parseplatformorg
Copy link
Contributor

parseplatformorg commented Nov 16, 2023

🎉 This change has been released in version 5.3.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Nov 16, 2023
beiguancyc pushed a commit to beiguancyc/parse-dashboard that referenced this pull request Nov 20, 2023
@cycqitianwushuge
Merge branch 'release'
178259d 
* release: (34 commits)
  chore(release): 5.3.0 [skip ci]
  release
  chore(release): 5.3.0-beta.1 [skip ci]
  release
  chore(release): 5.2.0-alpha.28 [skip ci]
  feat: Add security checks page (parse-community#2491)
  refactor: Security upgrade semver from 7.3.7 to 7.5.2 (parse-community#2493)
  refactor: Add lint and prettier (parse-community#2492)
  chore(release): 5.2.0-alpha.27 [skip ci]
  fix: Adding a file when adding a new row in the data browser doesn't show filename (parse-community#2471)
  chore(release): 5.2.0-alpha.26 [skip ci]
  fix: File extension is hidden in file field when editing object in modal dialog in data browser (parse-community#2472)
  chore(release): 5.2.0-alpha.25 [skip ci]
  fix: Incorrect highlight maker position in class list in data browser (parse-community#2490)
  chore(release): 5.2.0-alpha.24 [skip ci]
  feat: Add support for confirmation dialog before script execution in data browser (parse-community#2481)
  chore(release): 5.2.0-alpha.23 [skip ci]
  feat: Add parameter `selectedField` to script payload to determine which object field was selected when script was invoked (parse-community#2483)
  chore(release): 5.2.0-alpha.22 [skip ci]
  feat: Add refresh button to Cloud Config page (parse-community#2480)
  ...

# Conflicts:
#	package-lock.json
#	src/components/LogView/LogViewEntry.react.js
#	src/dashboard/Data/Jobs/Jobs.react.js
#	src/dashboard/Data/Jobs/JobsForm.react.js
#	src/lib/DateUtils.js
davimacedo pushed a commit to back4app/parse-dashboard that referenced this pull request Apr 4, 2024
@sadakchap @patelmilanun
@semantic-release-bot @mtrezza @parseplatformorg @AshishBarvaliya @cbaker6
Fix nogo bugs 3 (#611)
47c99da 
* feat: Add refresh indicator to Cloud Config page (parse-community#2505)

* chore(release): 5.3.0-alpha.2 [skip ci]

# [5.3.0-alpha.2](parse-community/parse-dashboard@5.3.0-alpha.1...5.3.0-alpha.2) (2023-10-18)

### Features

* Add refresh indicator to Cloud Config page ([parse-community#2505](parse-community#2505)) ([a10d1f0](parse-community@a10d1f0))

* release

* chore(release): 5.3.0 [skip ci]

# [5.3.0](parse-community/parse-dashboard@5.2.0...5.3.0) (2023-11-16)

### Bug Fixes

* Adding a file when adding a new row in the data browser doesn't show filename ([parse-community#2471](parse-community#2471)) ([5bbb94e](parse-community@5bbb94e))
* File extension is hidden in file field when editing object in modal dialog in data browser ([parse-community#2472](parse-community#2472)) ([8df4e4d](parse-community@8df4e4d))
* Incorrect highlight maker position in class list in data browser ([parse-community#2490](parse-community#2490)) ([8c28d24](parse-community@8c28d24))
* Pasting location coordinates into field of type `GeoPoint` does not work in data browser ([parse-community#2464](parse-community#2464)) ([a8ce343](parse-community@a8ce343))
* Selecting a saved filter in data browser also highlights other filters with equal names ([parse-community#2466](parse-community#2466)) ([35360fe](parse-community@35360fe))
* Vertical scrollbar in data browser is outside visible area when scrolling horizontally ([parse-community#2457](parse-community#2457)) ([5acac3f](parse-community@5acac3f))

### Features

* Add Cloud Function execution on Parse Object in data browser ([parse-community#2409](parse-community#2409)) ([996ce91](parse-community@996ce91))
* Add parameter `selectedField` to script payload to determine which object field was selected when script was invoked ([parse-community#2483](parse-community#2483)) ([e98d653](parse-community@e98d653))
* Add refresh button to Cloud Config page ([parse-community#2480](parse-community#2480)) ([be212b0](parse-community@be212b0))
* Add security checks page ([parse-community#2491](parse-community#2491)) ([103b9c6](parse-community@103b9c6))
* Add support for confirmation dialog before script execution in data browser ([parse-community#2481](parse-community#2481)) ([64d3913](parse-community@64d3913))
* Add typing with auto-complete to select a filter field in the data browser ([parse-community#2463](parse-community#2463)) ([257f76b](parse-community@257f76b))
* Reopen last opened class when navigating to data browser ([parse-community#2468](parse-community#2468)) ([3d7148e](parse-community@3d7148e))

### Reverts

* fix: Vertical scrollbar in data browser is outside visible area when scrolling horizontally ([parse-community#2457](parse-community#2457)) ([parse-community#2477](parse-community#2477)) ([2f1d84e](parse-community@2f1d84e))

* release

* chore(release): 5.4.0-beta.1 [skip ci]

# [5.4.0-beta.1](parse-community/parse-dashboard@5.3.0...5.4.0-beta.1) (2023-11-16)

### Features

* Add refresh indicator to Cloud Config page ([parse-community#2505](parse-community#2505)) ([a10d1f0](parse-community@a10d1f0))

* refactor: Security upgrade js-beautify from 1.14.6 to 1.14.10 (parse-community#2513)

* chore(release): 5.4.0-alpha.1 [skip ci]

# [5.4.0-alpha.1](parse-community/parse-dashboard@5.3.0...5.4.0-alpha.1) (2023-12-02)

### Features

* Add refresh indicator to Cloud Config page ([parse-community#2505](parse-community#2505)) ([a10d1f0](parse-community@a10d1f0))

* feat: Execute script for selected rows (parse-community#2508)

* chore(release): 5.4.0-alpha.2 [skip ci]

# [5.4.0-alpha.2](parse-community/parse-dashboard@5.4.0-alpha.1...5.4.0-alpha.2) (2023-12-16)

### Features

* Execute script for selected rows ([parse-community#2508](parse-community#2508)) ([5d9901e](parse-community@5d9901e))

* fix: Dashboard crashes if Parse Server Cloud Function script returns object (parse-community#2516)

* chore(release): 5.4.0-alpha.3 [skip ci]

# [5.4.0-alpha.3](parse-community/parse-dashboard@5.4.0-alpha.2...5.4.0-alpha.3) (2023-12-16)

### Bug Fixes

* Dashboard crashes if Parse Server Cloud Function script returns object ([parse-community#2516](parse-community#2516)) ([5de08f8](parse-community@5de08f8))

* fix: Data browser redirects to wrong class when changing app (parse-community#2526)

* chore(release): 5.4.0-alpha.4 [skip ci]

# [5.4.0-alpha.4](parse-community/parse-dashboard@5.4.0-alpha.3...5.4.0-alpha.4) (2024-02-15)

### Bug Fixes

* Data browser redirects to wrong class when changing app ([parse-community#2526](parse-community#2526)) ([7713f54](parse-community@7713f54))

* fix: Open pointer in new tab in data browser not working when mount path is not root (parse-community#2527)

* chore(release): 5.4.0-alpha.5 [skip ci]

# [5.4.0-alpha.5](parse-community/parse-dashboard@5.4.0-alpha.4...5.4.0-alpha.5) (2024-02-18)

### Bug Fixes

* Open pointer in new tab in data browser not working when mount path is not root ([parse-community#2527](parse-community#2527)) ([2f4081f](parse-community@2f4081f))

* fix: App metrics for user and installation counts show dash (parse-community#2528)

* chore(release): 5.4.0-alpha.6 [skip ci]

# [5.4.0-alpha.6](parse-community/parse-dashboard@5.4.0-alpha.5...5.4.0-alpha.6) (2024-02-26)

### Bug Fixes

* App metrics for user and installation counts show dash ([parse-community#2528](parse-community#2528)) ([850d7b3](parse-community@850d7b3))

* feat: Add descriptive statistics for number cells in data browser (parse-community#2529)

* chore(release): 5.4.0-alpha.7 [skip ci]

# [5.4.0-alpha.7](parse-community/parse-dashboard@5.4.0-alpha.6...5.4.0-alpha.7) (2024-02-26)

### Features

* Add descriptive statistics for number cells in data browser ([parse-community#2529](parse-community#2529)) ([ead9ec4](parse-community@ead9ec4))

* fix: Config page fails to load (parse-community#2531)

* chore(release): 5.4.0-alpha.8 [skip ci]

# [5.4.0-alpha.8](parse-community/parse-dashboard@5.4.0-alpha.7...5.4.0-alpha.8) (2024-02-29)

### Bug Fixes

* Config page fails to load ([parse-community#2531](parse-community#2531)) ([d721b7c](parse-community@d721b7c))

* feat: Add Node 20 support; remove Node 14, 16 support (parse-community#2532)

* feat: Add Node 20 support; remove Node 14, 16 support (parse-community#2535)

BREAKING CHANGE: Removes support for Node 14 and 16

* chore(release): 6.0.0-alpha.1 [skip ci]

# [6.0.0-alpha.1](parse-community/parse-dashboard@5.4.0-alpha.8...6.0.0-alpha.1) (2024-03-05)

### Features

* Add Node 20 support; remove Node 14, 16 support ([parse-community#2532](parse-community#2532)) ([578a339](parse-community@578a339))
* Add Node 20 support; remove Node 14, 16 support ([parse-community#2535](parse-community#2535)) ([5c90f2d](parse-community@5c90f2d))

### BREAKING CHANGES

* Removes support for Node 14 and 16 ([5c90f2d](5c90f2d))

* refactor: Security upgrade express from 4.18.1 to 4.19.2 (parse-community#2539)

* ci: Fix nginx config for preview environment (parse-community#2542)

* refactor: Upgrade to npm lockfile version 3 (parse-community#2543)

* fix: make cursor pointer for support more icon

* fix: more icon cursor pointer

* fix: remove console from B4aNotification

* feat: add light themed b4aEmptyState

* fix: B4aObjectPicker app crash when class exists not

* fix: cloudcode empty states

* fix: reduce size to remove scrollbar

* fix: remove extra space from REST Console top

* fix: dark themed dropdown arrow

* fix: error modal

* feat: add logRocket

---------

Co-authored-by: patelmilanun <20059797+patelmilanun@users.noreply.github.com>
Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
Co-authored-by: Manuel Trezza <5673677+mtrezza@users.noreply.github.com>
Co-authored-by: Parse Platform <90459499+parseplatformorg@users.noreply.github.com>
Co-authored-by: Ashish Baravaliya <49753983+AshishBarvaliya@users.noreply.github.com>
Co-authored-by: Corey <coreyearleon@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees

No one assigned

Labels

state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The file extension is hidden beneath the icon within the file cell in the edit modal

3 participants

@AshishBarvaliya @mtrezza @parseplatformorg