Merged
Conversation
when running with docker, as the local IP address is different from the dashboard all the security features would light up. This --dev flag let anyone run the dashboard locally easily
acinader
reviewed
Jan 24, 2019
Contributor
acinader
left a comment
acinader
left a comment
There was a problem hiding this comment.
The code seems fine to me.
Why would this be needed. How is this different from allowInsecureHTTP option?
Parse-Dashboard/index.js
Outdated
| const cookieSessionSecret = program.cookieSessionSecret || process.env.PARSE_DASHBOARD_COOKIE_SESSION_SECRET; | ||
| const trustProxy = program.trustProxy || process.env.PARSE_DASHBOARD_TRUST_PROXY; | ||
| const dev = program.dev; | ||
| console.log(dev); |
Contributor
There was a problem hiding this comment.
remove console.
Also, should probably make an env key too. PARSE_DEV?
Contributor
Author
|
This is different as it allows for bypassing user authentication requirement |
Contributor
|
right. |
acinader
approved these changes
Jan 25, 2019
acinader
suggested changes
Jan 25, 2019
Contributor
acinader
left a comment
acinader
left a comment
There was a problem hiding this comment.
see comment on console.log above
acinader
approved these changes
Jan 25, 2019
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when running with docker, as the local IP address is different from the dashboard
all the security features would light up.
This --dev flag let anyone run the dashboard locally easily