Break schemaController dependency.#1901
Merged
peterdotjs merged 17 commits intoparse-community:masterfrom May 25, 2016
Merged
Conversation
ghost
added
the
| expected = schema.getExpectedType(className, key); | ||
| } | ||
| if ((expected && expected.type == 'Pointer') || (!expected && restValue && restValue.__type == 'Pointer')) { | ||
| if ((parseFormatSchema.fields[key] && parseFormatSchema.fields[key].type === 'Pointer') || (!parseFormatSchema.fields[key] && restValue && restValue.__type == 'Pointer')) { |
Contributor
There was a problem hiding this comment.
may be worth null checking parseFormatSchema and parseFormatSchema.fields
Contributor
Author
There was a problem hiding this comment.
Part of the contract we are going to make with the DB adapters is that we always provide a valid schema. All validation is going to happen inside Parse Server, so if those are ever null, we should actually crash and not just go forward without knowing what the real schema is.
maninga
added a commit
to maninga/parse-server
that referenced
this pull request
May 26, 2016
* upstream/master: (63 commits) Fixes parse-community#1649 (parse-community#1650) Update issue template (parse-community#1899) Break schemaController dependency. (parse-community#1901) Remove unnecessary null check Update schema mismatch error to include type string (parse-community#1898) Move more mongo specific stuff into mongo adapter Kill mongoOptions Consistent parameter order move transformWhere into mongo adapter Remove options from count Can't sort a count Remove limit from count Destructure mongo options remove adaptive collection call create + use adapter count instead of collection count transformWhere in MongoAdapter remove schemaController paramater Remove schemaController parameter Remove getRelationFields Remove all dependencies on schemaController ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Break more dependencies on schemaController.
Also most some validation out of the adapter and into the server.