Add push parameter checking and query installation

[wangmengyan95]

This is the first step to implementing the push system in parse-server. In this PR, I add

1. Parameter checking
2. Run the installation query
   Since it is not finished yet, the api will still return error.

[wangmengyan95]

cc @bnham @fantasist for review

[nlutsenko]

Please rebase after #196 is merged.

[wangmengyan95]

@nlutsenko sure, will do that.

[wangmengyan95]

Is this a good way to expose internal methods for testing purpose? I follow the same way we do in JS and React repo, but I am not so confident about this. @peterdotjs @hallucinogen

[gfosco]

We have used TESTING=1 which loads testing-routes, you could re-use that.

[wangmengyan95]

@gfosco , haha, then I know why we have TESTING=1. But it seems we have a bug here. I remember all parameters in process.env is string so process.env.TESTING == 1 will always return false. Could you double check that?
If TESTING = 1 is just for test purpose, probably using process.env.NODE_ENV is a better idea. It is more common use than setting random variable and we can get rid of the integer/string stuff. I will send a PR if you do not mind.

[gfosco]

Yeah that sounds fine to replace TESTING with NODE_ENV. Pretty sure JS coerces "1" == 1 just fine, it's "1" === 1 that would fail.

[hallucinogen]

Commenting the original question: yes the check looks fine. Just make sure it's consistent across the code. In JS SDK we achieve this by caching the value in some JSON config https://github.com/ParsePlatform/Parse-SDK-JS/blob/master/src/CoreManager.js#L111

[bnham]

In the API, we allow expiration_time to be either a number or a string. If it's a number, then it's the number of seconds since the unix epoch. If it's a string, it's an ISO8601 string.

So this needs to be something like:

expirationTimeParam = body['expiration_time'];
if (typeof expirationTimeParam == 'number') {
  // date constructor wants ms since epoch, not seconds
  expirationTime = new Date(expirationTimeParam * 1000);
} else if (typeof expirationTimeParam == 'string') {
  expirationTime = new Date(expirationTimeParam);
}

[wangmengyan95]

👍

[facebook-github-bot]

@wangmengyan95 updated the pull request.

[facebook-github-bot]

@wangmengyan95 updated the pull request.

[bnham]

This seems like it might be some left over code from before? expirationTime is a Date, doesn't seem like it makes sense to call isFinite on it

[wangmengyan95]

Nope, isFinte can be used to check Date object directly, since it will auto transfer Date to number. If Date is invalid, it will return false, otherwise it will return true.

[bnham]

LGTM, take a look at that isFinite call