Lookup for email in username field to match docs if email is undefined#2732
Merged
flovilmart merged 3 commits intomasterfrom Sep 18, 2016
Merged
Lookup for email in username field to match docs if email is undefined#2732flovilmart merged 3 commits intomasterfrom
flovilmart merged 3 commits intomasterfrom
Conversation
ghost
added
the
|
@flovilmart updated the pull request - view changes |
This was referenced Sep 19, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2502
When the email is not set on the user, the docs expressively says that the server should lookup in the username field.
This PR propose that change.
Note that the adapters should adapt to that change if implementing
sendPasswordResetEmail, and lookup in the username field is email is not set.If the adapter like parse-server-simple-mailgun-adapter only implements
sendMailno change is required.