Improve update of jsonb fields. Add PG 9.5 to travis.#2984
Merged
flovilmart merged 2 commits intoparse-community:masterfrom Nov 2, 2016
Merged
Improve update of jsonb fields. Add PG 9.5 to travis.#2984flovilmart merged 2 commits intoparse-community:masterfrom
flovilmart merged 2 commits intoparse-community:masterfrom
Conversation
Contributor
|
You're on fire! |
Contributor
Author
|
Given that the alternative would be to build something eerily similar to parse server (using postgres instead of mongodb), I'm just trying to do what I can to make parse server work with Postgres 😄 |
Contributor
|
Eheh the bases are pretty solid! Thanks for all your contributions and the ones to come! |
|
@kulshekhar updated the pull request - view changes |
1 similar comment
|
@kulshekhar updated the pull request - view changes |
Contributor
|
tests seem to fail on travis but I can't see the logs :/ |
Contributor
Author
|
same here. It's happening with some other repos too. |
Contributor
Author
|
For the postgres specific builds that fail, it's a bit weird. If it doesn't fail on both 4.5 and 6.1, chances are that rebuilding the test for the failed version will pass |
Contributor
|
Looking 👍 |
This was referenced Jun 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the travis config and updates of jsonb fields in the following manner:
Travis:
sudotorequiredprecisedistribution withtrustyThe last two changes are required because Travis doesn't seem to have a simple way of using Postgres 9.5 with precise (with or without sudo) and it needs sudo on trusty
Update of
jsonbfieldsThis PR also enables one existing test to run against Postgres