Fix for unhandled undefined config

[bryandel]

When an invalid application id is passed either for reset/change password or email verification, config.get returns undefined. This causes internal server.

[codecov]

Codecov Report

Merging #4334 into master will increase coverage by 0.01%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##           master    #4334      +/-   ##
==========================================
+ Coverage   92.52%   92.54%   +0.01%     
==========================================
  Files         118      118              
  Lines        8258     8273      +15     
==========================================
+ Hits         7641     7656      +15     
  Misses        617      617

Impacted Files	Coverage Δ
src/Routers/PublicAPIRouter.js	91.58% <93.33%> (+0.28%)	⬆️
src/RestWrite.js	93.39% <0%> (ø)	⬆️
src/Adapters/Auth/meetup.js	89.47% <0%> (+5.26%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 932a474...9ce201c. Read the comment docs.

[montymxb]

Nice catch. The standard 'Not found.' & '404' response seems ok, @flovilmart think we're good using the existing missingPublicServerURL for this as well?

[flovilmart]

We should probably throw if Config.get(appId) don’t return anything no?

[montymxb]

Something like this?

throw new Parse.Error(Parse.Error.OTHER_CAUSE, 'appId not found');

or maybe OBJECT_NOT_FOUND? Not too many codes we could match to this unless we wanted to use INTERNAL_SERVER_ERROR.

[flovilmart]

What do we usually throw when making a request with an invalid appId? Unauthorized I guess .)

[montymxb]

No specific cases come to mind actually, just You must provide an appId! in ParseServer.js and ...appIds or appSecret is incorrect. in vkontakte.js. What if we made the message just

appId is incorrect

Simple and to the point. Both of those other refs just throw errors, the latter uses OBJECT_NOT_FOUND.

[montymxb]

@bryandel if you can split up the checking on the config and throw instead that would be fantastic 👍 .

[montymxb]

Would you be willing to update this to handle !config separately? We would like to throw an exception rather than return a standard 404. Something like this should do

if (!config) {
    throw new Parse.Error(Parse.Error.OTHER_CAUSE, 'appId does not exist in config.');
}

[flovilmart]

following in middleware.js if appId can't be found, this should be

if (!config)  {
    const error = new Error();
    error.status = 403;
    error.message = "unauthorized";
    throw error;
}

The error will be handled by the PromiseRouter and transformed in to the proper response.

[montymxb]

Ahh, didn't see that initially. @bryandel take flovilmart's suggestion for the proper error to report.

[montymxb]

Same here

[montymxb]

and here

[montymxb]

same

[montymxb]

same

[bryandel]

Thank you for the suggestions. I have changed the implementation and also added tests for the code coverage. But it seems in the last build a different test has failed

update android device token with duplicate device token
- Expected 1 to equal 0.

[montymxb]

@bryandel thanks again for the PR!