add support for geoWithin.centerSphere queries via withJSON

[mtrezza]

This allows an unsorted geo query via withJSON as a faster performing alternative to the sorted geo queries of withinKilometers, withinMiles and withinRadius if sorting by distance is not needed.

[mtrezza]

As described in this issue #4824

[codecov]

Codecov Report

Merging #4825 into master will increase coverage by <.01%.
The diff coverage is 98%.

@@            Coverage Diff             @@
##           master    #4825      +/-   ##
==========================================
+ Coverage   92.72%   92.73%   +<.01%     
==========================================
  Files         119      119              
  Lines        8688     8722      +34     
==========================================
+ Hits         8056     8088      +32     
- Misses        632      634       +2

Impacted Files	Coverage Δ
...dapters/Storage/Postgres/PostgresStorageAdapter.js	97.2% <100%> (-0.05%)	⬇️
src/Adapters/Storage/Mongo/MongoTransform.js	87.12% <96.77%> (+0.29%)	⬆️
src/Adapters/Auth/meetup.js	84.21% <0%> (-5.27%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 260c466...c0f8770. Read the comment docs.

[dplewis]

@mtrezza This was requested a while ago but never made it in.

#4060 You can use this as a reference.

[mtrezza]

@dplewis Can you please help me out on this one, Travis CI failed for postgres with:

Parse.Query testing toJSON works with geoWithin.centerSphere

• Failed: Postgres doesn't support this query type yet {"$geoWithin":{"$centerSphere":[{"__type":"GeoPoint","latitude":0,"longitude":0},0.24642913200439492]}}

I think the $centerSphere query only makes sense for mongoDB as it is a different DB query with a performance advantage compared to $nearSphere.$maxDistance.

Now I added the logic to PostgresStorageAdapter.js but technically it is the same DB request as this existing one, just without the sorts line:

parse-server/src/Adapters/Storage/Postgres/PostgresStorageAdapter.js

Lines 516 to 523 in e064716

	if (fieldValue.$nearSphere) {
	const point = fieldValue.$nearSphere;
	const distance = fieldValue.$maxDistance;
	const distanceInKM = distance * 6371 * 1000;
	patterns.push(`ST_distance_sphere($${index}:name::geometry, POINT($${index + 1}, $${index + 2})::geometry) <= $${index + 3}`);
	sorts.push(`ST_distance_sphere($${index}:name::geometry, POINT($${index + 1}, $${index + 2})::geometry) ASC`)
	values.push(fieldName, point.longitude, point.latitude, distanceInKM);
	index += 4;

I saw that tests can be DB specific with it_only_db('mongo'). So should I keep the changes to PostgresStorageAdapter.js or make the test mongoDB specific?

[flovilmart]

I’ll review tomorrow first thing!

[mtrezza]

@flovilmart do you know why the coverage for meetup.js changed? I haven’t changed anything in the file or changed any existing tests.

[flovilmart]

@mtrezza this are false positives

[mtrezza]

@flovilmart Can you give me a hint on how to make parse-server use my local clone of the JS SDK or vice-versa? Then I'll add the convenience functions like withinKilometersUnsorted to the JS SDK. In a new PR that is.

[flovilmart]

You can use npm link to provide a temporary link between packages

https://docs.npmjs.com/cli/link

[flovilmart]

Looking good!