Ensure read preference is never overriden, so DB config prevails#4833
Merged
flovilmart merged 1 commit intomasterfrom Jun 13, 2018
Merged
Ensure read preference is never overriden, so DB config prevails#4833flovilmart merged 1 commit intomasterfrom
flovilmart merged 1 commit intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4833 +/- ##
==========================================
- Coverage 92.74% 92.74% -0.01%
==========================================
Files 119 119
Lines 8722 8721 -1
==========================================
- Hits 8089 8088 -1
Misses 633 633
Continue to review full report at Codecov.
|
acinader
approved these changes
Jun 13, 2018
Contributor
acinader
left a comment
acinader
left a comment
There was a problem hiding this comment.
this looks right to me.
My assumption is that you added this six months ago to fix some failing tests and then realized that it was whacking a config, so this is to just fix the tests and revert the previous test.....
Contributor
Author
|
Thar’s basically It, the original assumption was that setting PRIMARY was to set back the original behavior, BUT, that was wrong! |
flovilmart
added a commit
that referenced
this pull request
Aug 12, 2018
flovilmart
added a commit
that referenced
this pull request
Aug 12, 2018
UnderratedDev
pushed a commit
to UnderratedDev/parse-server
that referenced
this pull request
Mar 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4831