"Object not found." instead of "Insufficient auth." when using master key#5133
Merged
flovilmart merged 4 commits intoparse-community:masterfrom Oct 22, 2018
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5133 +/- ##
=======================================
Coverage 93.84% 93.84%
=======================================
Files 123 123
Lines 8923 8923
=======================================
Hits 8374 8374
Misses 549 549
Continue to review full report at Codecov.
|
flovilmart
approved these changes
Oct 22, 2018
Contributor
|
Thanks @georgesjamous! |
UnderratedDev
pushed a commit
to UnderratedDev/parse-server
that referenced
this pull request
Mar 21, 2020
… key (parse-community#5133) * add additional isMaster check * adding some tests * nits * covering all basis
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A minor change that will return "Object not found.", instead of "Insufficient auth." when using a master key. Which seems to be more appropriate since the masterKey has the highest authority.
Issue: #5129