Conversation
|
I'd love to quantify how much time this will save per request, I suspect it'll be quite noticeable at scale. Nice work. |
README.md
Outdated
There was a problem hiding this comment.
maybe added something like: 'Caution, this is an experimental feature that may not be appropriate for production'
There was a problem hiding this comment.
We should remove this section, organize the definition in alphabetical order and replace with http://parseplatform.org/parse-server/api/3.3.0/ParseServerOptions.html
src/Options/docs.js
Outdated
There was a problem hiding this comment.
add default false. also should point out that it is experimental
There was a problem hiding this comment.
I realized updating Parse Server config definitions isn't documented and isn't run on every PR. I can submit a separate PR for that
|
@omairvaiyani the reason that it hasn't been turned on is because the unit tests fail. @dplewis you could add this to the travis matrix and just make it optional so we can at least see what we're up against? |
Codecov Report
@@ Coverage Diff @@
## master #5550 +/- ##
==========================================
- Coverage 94.01% 93.99% -0.03%
==========================================
Files 129 129
Lines 9192 9192
==========================================
- Hits 8642 8640 -2
- Misses 550 552 +2
Continue to review full report at Codecov.
|
This reverts commit 407f138.
|
@acinader I reverted travis.yml because the matrix stakes too long. At least we can see what some of the problems are. Looks like there are issues with CLP, ACL, MasterKey and SessionToken. https://travis-ci.org/parse-community/parse-server/jobs/529921508 Besides that, how does this look? |
acinader
left a comment
acinader
left a comment
There was a problem hiding this comment.
it looks good to me.
see my question.
| 'Protected fields that should be treated with extra security when fetching details.', | ||
| action: parsers.objectParser, | ||
| default: { _User: { '*': ['email'] } }, | ||
| default: [], |
There was a problem hiding this comment.
why the change to the default?
There was a problem hiding this comment.
This is autogenerated. Parser doesn't exist for this json. I can fix this in a separate PR.
* Support direct access config test options * add test * fix test * fix definitions * improve docs * Update .travis.yml * Revert "Update .travis.yml" This reverts commit 407f138.
3 participants
Closes: #5442
Let me know if I missed anything or wording needs clarifying. I've never added a server config option before.