Keycloak auth adapter#6376
Keycloak auth adapter#6376davimacedo merged 6 commits intoparse-community:masterfrom rhuanbarreto:keycloak-auth-adapter
Conversation
Merge parse server repository
|
I also left a PR in the docs repository for the documentation. |
Codecov Report
@@ Coverage Diff @@
## master #6376 +/- ##
==========================================
- Coverage 93.82% 93.80% -0.02%
==========================================
Files 168 169 +1
Lines 12190 12220 +30
==========================================
+ Hits 11437 11463 +26
- Misses 753 757 +4
Continue to review full report at Codecov.
|
|
@dplewis @flovilmart @davimacedo Can you merge? |
|
@rhuanbarreto Sorry for the late reply. Can you add test cases? Everything looks good just want to make sure we have coverage. |
|
The test cases are bound to have a keycloak running. Should I add something like this in the test suite? |
|
You can try to mock it. Or maybe use a "test endpoint". I am not sure they have one. You can refer to these tests: https://github.com/parse-community/parse-server/blob/master/spec/AuthenticationAdapters.spec.js |
|
I made the change to increase coverage and on Travis the errors are not related to my code changes. Can you please check @davimacedo @dplewis ? |
|
Could you please add more tests? Something like these ones. |
|
Sorry. I don't have time anymore for adding these tests. If it's not enough, you can close the PR. |
|
@rhuanbarreto I added a few tests cases. Can you review this? |
|
Tests are fine! You can merge. |
|
@davimacedo @dplewis are you able to merge? |
Implemented a keycloak authentication adapter. I'm using it already for more than 6 months normally as a custom module. Keycloak runs connecting to 2 LDAP servers and provide a centralized ID management system with roles and groups mapping to LDAP groups.