Merged
Conversation
Improve `createClass` transaction: * `await` makes it a more consistent sequence of queries * `batch` is not needed there * No need for an extra `.then` section
|
Danger run resulted in 1 fail and 1 markdown; to find out more, see the checks page. Generated by 🚫 dangerJS |
Codecov Report
@@ Coverage Diff @@
## master #6989 +/- ##
=======================================
Coverage 93.81% 93.82%
=======================================
Files 169 169
Lines 12409 12405 -4
=======================================
- Hits 11642 11639 -3
+ Misses 767 766 -1
Continue to review full report at Codecov.
|
Remove batch-dependent error code check, as it should happen automatically without batch result.
Removing unused variable.
Contributor
Author
|
Looks better now 😄 Little steps. |
Contributor
Author
|
@dplewis Should be good for merging ;) |
dblythy
pushed a commit
to dblythy/parse-server
that referenced
this pull request
Dec 14, 2020
* Update PostgresStorageAdapter.js Improve `createClass` transaction: * `await` makes it a more consistent sequence of queries * `batch` is not needed there * No need for an extra `.then` section * Update PostgresStorageAdapter.js Remove batch-dependent error code check, as it should happen automatically without batch result. * Update PostgresStorageAdapter.js Removing unused variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve
createClasstransaction:awaitmakes it a more consistent sequence of queriesbatchis not needed there.thensection